Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duffel bag & backpack material / recipe fix #12443

Merged
merged 5 commits into from May 24, 2015

Conversation

Projects
None yet
5 participants
@tvm1
Copy link
Contributor

commented May 23, 2015

As mentioned by Chezzo, it was possible to craft duffel bag with rags only and disassemble it for rags and plastic chunks. Also alternative materials for crafting recipe didn't made much sense (fur/leather/etc.), duffel bags are made of cotton and yield rags on disassembly.

Same problem applies to backpack.

@tvm1 tvm1 changed the title Duffel bag material / recipe fix Duffel bag & backpack material / recipe fix May 23, 2015

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 23, 2015

Crafting a duffel bag using nothing but rags, having to cut it apart due to current character having the Huge trait...getting 10 rags and 10 plastic chunks.

Chezzo wasn't the only one to comment on this. :V

@tvm1

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2015

Oh well.

/me gives cookie to chaosvolt.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 23, 2015

Huehuehue. o3o

I'm sure there are other items with similar issues as well, but would need to mess around with finding them. I do recall that I'm fairly certain that steel-toed boots have the "no salvage" token to prevent turning them into scrap metal.

@tvm1

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2015

Today, I've had some beers and being enlightened, i'm writing some kind of sanity checker for that stuff.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 23, 2015

Should be entertaining to see. owo

@kevingranade

This comment has been minimized.

Copy link
Member

commented May 23, 2015

The general fix for this was supposed to be the fact that survivor-crafted items have the actual items used to craft them stored with the item, and you get them back if you disassemble them, is this broken now?

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented May 23, 2015

is this broken now?

Last I knew it was still working, but I haven't tested it in a while.


edit: It still works properly when disassembling, just not when you cut the item to pieces with a knife.

@kevingranade

This comment has been minimized.

Copy link
Member

commented May 23, 2015

Aah, you mean it can be "cut up" for plastic chunks. If you have a way of having that operation make sense and return the right items, please do so, but we're not removing a bunch of crafting options to make it happen.
We could probably check if it's a crafted item and select items from the list to return instead of using the normal cut up code.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented May 23, 2015

Material tweaks would be the logical fix for cutting, or applying the NO_SALVAGE token.

Cutting stuff up can cause a lot of silly results at times.

@tvm1

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2015

Fair enough then. I've reverted the recipe commit, so only the plastic removal remains.

I've found some other items which yield materials that are not used in the crafting recipe and will address theme in separate PR.

@Coolthulhu Coolthulhu self-assigned this May 24, 2015

Coolthulhu added a commit that referenced this pull request May 24, 2015

Merge pull request #12443 from tvm1/duffelbag-fix
Duffel bag & backpack material / recipe fix

@Coolthulhu Coolthulhu merged commit 253d737 into CleverRaven:master May 24, 2015

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@tvm1 tvm1 deleted the tvm1:duffelbag-fix branch May 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.