Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded noise support for reloading #12449
Conversation
CIB
added some commits
May 23, 2015
This comment has been minimized.
This comment has been minimized.
|
this I like |
This comment has been minimized.
This comment has been minimized.
|
Maybe I should add the noise strings/loudness to various types of guns in the JSON, but I don't know the first thing about guns or how reloading them sounds. |
kevingranade
merged commit 4832aa4
into
CleverRaven:master
May 23, 2015
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
This sounds like a grand idea; most firearms make very little sound when reloaded (contrary to what Hollywood and vidjagames would lead you to believe) and stuff like bows and crossbows are pretty much silent unless you're super clumsy. |
This comment has been minimized.
This comment has been minimized.
|
Just fyi, added a check for volume <= 0 while merging, I'm not sure it
makes sense to repeat that check, or to have the function silently bail out
when volume is negative or zero.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
CIB commentedMay 23, 2015
No description provided.