Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore Survival Tools Series 9 #12647
Conversation
added some commits
Jun 13, 2015
This comment has been minimized.
This comment has been minimized.
|
nice! |
This comment has been minimized.
This comment has been minimized.
|
I would also note that a few of the cartridges available historically originated in the blackpowder era. I didn't add the option to them because it would be a bit odd to run blackpowder cartridges through autoloading guns. o3o |
Coolthulhu
reviewed
Jun 13, 2015
| "warmth" : 10, | ||
| "phase" : "solid", | ||
| "environmental_protection" : 0, | ||
| "encumbrance" : 15, |
This comment has been minimized.
This comment has been minimized.
Coolthulhu
Jun 13, 2015
Contributor
For something that leaves just a thin slit to see through, this sounds way too low.
Coolthulhu
reviewed
Jun 13, 2015
| [ | ||
| [ "charcoal", 15 ] | ||
| ] | ||
| ] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Since gunpowder is going to become uncraftable, you could push gunpowder as a separate PR into mainline. |
Coolthulhu
self-assigned this
Jun 13, 2015
This comment has been minimized.
This comment has been minimized.
|
Continually adding all these things into a mod is only going to make it into a longer process when we pull them into the mainline. Why not just PR your stuff for the mainline in the first place? |
This comment has been minimized.
This comment has been minimized.
|
Good point. |
This comment has been minimized.
This comment has been minimized.
|
Meep. Maybe should PR the blackpowder idea then. =w= Also, I should note I copy-pasted the blackpowder recipe from the recipe file, so if the formatting is FUBAR it wasn't my mistake. :V |
Coolthulhu
removed their assignment
Jun 13, 2015
This comment has been minimized.
This comment has been minimized.
|
Swiggity swooty: #12656 |
added some commits
Jun 13, 2015
Coolthulhu
self-assigned this
Jun 15, 2015
Coolthulhu
added a commit
that referenced
this pull request
Jun 15, 2015
Coolthulhu
merged commit c963912
into
CleverRaven:master
Jun 15, 2015
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Meep. And thank you for the merge. ^^ |
chaosvolt commentedJun 13, 2015