Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix libc complaining about invalid printf string #12649
Conversation
This comment has been minimized.
This comment has been minimized.
tvm1
commented on 3ecd65d
Jun 13, 2015
|
Thanks for fixing that. Grepping through the sources, it seems that this is not the only instance of this problem. |
This comment has been minimized.
This comment has been minimized.
Well, it was new for me, too. So I've learned something (-:
Where else does it happen? I checked the sources as well, but didn't found any similar problem. |
This comment has been minimized.
This comment has been minimized.
Ah, sorry my bad, it works everywhere now. All the functions seem to actually use the passed arguments for both player & NPC , so it works even with |
Coolthulhu
self-assigned this
Jun 13, 2015
Coolthulhu
added a commit
that referenced
this pull request
Jun 13, 2015
BevapDin commentedJun 13, 2015
This has been reported at http://smf.cataclysmdda.com/index.php?topic=10419.msg236893#msg236893 and http://smf.cataclysmdda.com/index.php?topic=10477.0 (I believe they stem from the same bug).
A bug report that explains the problem: https://bugs.launchpad.net/ubuntu/+source/gcc-4.4/+bug/547016
Reproducible with gcc 5.1.0 and -O3 and
-D_FORTIFY_SOURCE=2, it woks "fine" (does not crash) without any-Oflag, and also with-D_FORTIFY_SOURCE=0.