Changes to rifle rounds

[ghost]

Context: http://smf.cataclysmdda.com/index.php?topic=10693.0

Changes:
Renamed 5N7 to 7N10
Changed damage for all 7.62x39mm rounds, all 5.45x39mm rounds, .223, and .308
Changed descriptions for all 7.62x39mm rounds, all 5.45x39mm rounds, .223, and .308
Minor changes to recoil/accuracy/pierce for all affected rounds

[chaosvolt]

Ah, interesting. For once I'm not to blame for any oddities on the 5.45x39mm, as I ported the ammo straight from Icecoon's Weapons Pack.

[kevingranade]

Side note, since we're deriving our damage values from real-world stats now, we need that explained somewhere and either a table of those real-world stats or a link to them. Otherwise someone is going to come along and tweak the values for some reason.

[chaosvolt]

That would be good to have references, yes. As I've found when statting out firearms, that can be hard to come by at times.

[ghost]

I'll compile a list of values and relevant information used for each round. Should I include it in the repo or keep it external?

[kevingranade]

I think it should go in the doc/ folder in a new file.

[ghost]

Got it. I'll sort that out tomorrow.

[Coolthulhu]

60 is a lot

[ghost]

Added AMMO_STATS.txt with all relevant info for this PR. I'll update it for the last one when I find the figures.

Semi-OT: Why are the files in ./doc/ all caps?

[karlnp]

IIRC documents are written in all-caps historically so they show at the head of a directory listing.

[chaosvolt]

Are you plotting a tweak to .50 BMG anytime soon? 10 rounds of AP and API take up the same 2 volume that 30 rounds of Ball do, because someone forgot that stack size is a thing. o3o

[ghost]

@chaosvolt Fixed.

[chaosvolt]

...I said volume. >_>

In fact, you made the variants way lighter than the normal ammo. Weight controls weight per bullet, not weight per stack. Volume controls how much volume a stack counts as, count controls how much is considered a stack IF stack_size is undefined, and stack_size is, well...what I was saying should've been added.

EDIT: For reference, regular .50 BMG Ball has a count of 30 and a volume of two, meaning 30 bullets is 2 volume (and 15 bullets is 1 volume). The AP and AP variants have the same volume but a count of 10, meaning that same 30 bullets would be 6 volume instead, because whoever added them in the first place forgot to add "stack_size" : 30 to them.

[ghost]

10 .50 rounds now take one volume instead of 0.6 with stack sizes being accounted for. This is reasonable given the size of the ammunition.

[chaosvolt]

EDIT: Ah, I see. You upped the volume of the regular version, and lowered the AP versions to match. Nevermind then.

[ghost]

All 3 types have the same volume per round now. Stack size is the only difference.

Different bullets can't be significantly larger than standard ball because they would not fit in .50 cases.

[chaosvolt]

As I see. Sorry about that.

[ghost]

That's all the rifle rounds done. This is ready to merge now.

[chaosvolt]

Ooh, interesting. I do regret that we can't have the tracer properties show up on an "every few shots" basis, so as it is every round fired from the tracer mix has its incendiary properties.

[ghost]

If I can work out how ranged.cpp works I might try to implement that. I have the c++ skills of a caveman so I doubt it will be done soon, if ever.

[chaosvolt]

No idea how to implement such a thing either. I'm struggling with rather basic things like adding vehicle groups to mapgen_functions.cpp.

[karlnp]

adds it to his pile