Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAmmo changes #12988
Conversation
added some commits
Jul 18, 2015
This comment has been minimized.
This comment has been minimized.
|
This is ready to merge now. |
ghost
changed the title
[WiP] Ammo changes
Ammo changes
Jul 27, 2015
Rivet-the-Zombie
self-assigned this
Jul 27, 2015
This comment has been minimized.
This comment has been minimized.
|
I guess this means I can't put off updating caseless stuff any longer. |
Rivet-the-Zombie
added a commit
that referenced
this pull request
Jul 27, 2015
Rivet-the-Zombie
merged commit 0a526bf
into
CleverRaven:master
Jul 27, 2015
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Since when did DDA item descriptions employ two spaces for new sentences? Since when did ANYONE in the 21st century do that? |
This comment has been minimized.
This comment has been minimized.
|
Double spacing after sentences is easy to read on any terminal settings. We have a manual of style that covers proper formatting for in-game text. |
This comment has been minimized.
This comment has been minimized.
|
Two spaces is and has always been the correct thing to use when your font
is fixed width, our fonts are fixed width.
The 'modern' change to using a single space is solely based on the use of
proportional-width fonts.
|
This comment has been minimized.
This comment has been minimized.
|
Nobody checked these numbers for consistency? .45 ACP weaker than 9mm? 10mm Auto same power as .40 S&W (short and weak)? |
This comment has been minimized.
This comment has been minimized.
|
@ejseto the numbers are derived from the factors listed in AMMO_STATS.txt. Other factors are not accounted for. Implement them if you see fit. |
ghost commentedJul 18, 2015
Context: http://smf.cataclysmdda.com/index.php?topic=10693.0
Changes:
See commits.