Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazemod update 2 #13128

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@chaosvolt
Copy link
Contributor

commented Jul 30, 2015

Once again PR'ing it for Blaze, in case any fixes on the latest version on mediafire aren't in the github version. Additionally, made sure to retain the water tank mainlining, turret volume fixes, and mounted weapon overrides from last update.

And finally, removed the "needs a battery mount" from the mounted laser, as it would presumably break things. Also added the mounted laser rifle to overrides, which I didn't do last time because copying "NEEDS_BATTERY_MOUNT" from the other mounted laser hindered things.

chaosvolt
Blazemod update 2
Once again PR'ing it for Blaze, in case any fixes on the latest version
on mediafire aren't in the github version. Additionally, made sure to
retain the water tank mainlining, turret volume fixes, and mounted
weapon overrides from last update.

And finally, removed the "needs a battery mount" from the mounted laser,
as it would presumably break things. Also added the mounted laser rifle
to overrides, which I didn't do last time because copying
"NEEDS_BATTERY_MOUNT" from the other mounted laser hindered things.
@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 30, 2015

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2015

if need be a script could always be added to simply convert one \t into x spaces.

@Barhandar

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2015

at some point blaze needs to sync from the main project, or this is going to keep being a problem.

And set their text editor to use spaces instead of tabs so it doesn't repeat. Notepad++ can do that.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2015

Most, if not all, programming editors can do that.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2015

Ack. Crap. Sorry, I kinda just copy-pasted Blaze's work and re-added the latest divergences.

Unfortunately that's kinda Blaze's error, if he's adding tab issues. ._.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2015

Okay, I'm working on fixing this myself...

chaosvolt
Format Defuckifying
Simply went and overrode the copy-pasting that caused all these
formatting fails, then checked for any actual CHANGES.
@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 31, 2015

if need be a script could always be added to simple convert one \t into x
spaces.

How many spaces is x? In practice, it's either 8 or 4, unless it's
adaptive, in which case it's anything in between 1 and 8.
Basically if we could run astyle on the code in question it would sort it
out, but nothing less sophisticated than that is going to be able to fix it
without human intervention.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2015

It should be fixed now, plus some tabs I found that seem to have still been in the Github version.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2015

where x is the number of spaces you want? I thought that was implied...

Plus, I forget about astyle sometimes, that's a better idea.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2015

Hmm. Somebody pester me if they find more tabs. @_@

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2015

an easy way to fix this is to use the search and replace function, simply change \t to ' ' (4 spaces).

(Vim Users-> :%s /\t/ /g)

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2015

Hmm, could work. Or just find in general so I ensure I give the right amount of spaces.

@DavidKeaton

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2015

True this, however automating it makes doing faster!

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2015

Maybe. On it, in any case.

chaosvolt
More tab-hunting
Should be all the irksome tabs now.
@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2015

I would hope that I've finally weeded out the tabs and space failures by now. <.<

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2015

Why the hell is this giving a merge conflict NOW, and why did no one mention this?

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2015

Augh. I've got other things to fix, we aren't really missing much if I close this.

@chaosvolt chaosvolt closed this Aug 12, 2015

@chaosvolt chaosvolt deleted the chaosvolt:blazemod-updates-2 branch Oct 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.