Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace SDLTILES with just TILES #13235
Conversation
kevingranade
self-assigned this
Aug 12, 2015
kevingranade
merged commit f734793
into
CleverRaven:master
Aug 12, 2015
1 check failed
default
Details
BevapDin
deleted the
BevapDin:SDLTILES
branch
Aug 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedAug 10, 2015
Because it's redundant and used inconsistently.
For example in sdltiles.cpp the global
needupdateis only defined ifSDLTILESis defined, but it's often used in places where this is not checked, e.g.CheckMessages. Similar:init_interfaceis not defined (but used in main.cpp) if onlyTILESis defined but notSDLTILES. And of course, the various make/project files already define both anyway.I choose to keep
TILESand notSDLTILESbecause that's what is already used in the Makefile and when invokingmake TILES=1, so it's kind of consistent.