Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SDLTILES with just TILES #13235

Merged
merged 1 commit into from Aug 12, 2015

Conversation

Projects
None yet
2 participants
@BevapDin
Copy link
Contributor

commented Aug 10, 2015

Because it's redundant and used inconsistently.

For example in sdltiles.cpp the global needupdate is only defined if SDLTILES is defined, but it's often used in places where this is not checked, e.g. CheckMessages. Similar: init_interface is not defined (but used in main.cpp) if only TILES is defined but not SDLTILES. And of course, the various make/project files already define both anyway.

I choose to keep TILES and not SDLTILES because that's what is already used in the Makefile and when invoking make TILES=1, so it's kind of consistent.

@kevingranade kevingranade self-assigned this Aug 12, 2015

@kevingranade kevingranade merged commit f734793 into CleverRaven:master Aug 12, 2015

1 check failed

default
Details

@BevapDin BevapDin deleted the BevapDin:SDLTILES branch Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.