Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes and update #13240

Merged

Conversation

Projects
None yet
3 participants
@VlasovVitaly
Copy link
Contributor

commented Aug 10, 2015

Translations template update
From 03 Aug => 10 Aug.

Fixes of some annoying translations bug.

  • Empty string as gettext() argument in player status menu.
    lvoehxt
  • Same error in any item info menu. Storing translated strings in object not so good idea but this behaviour is related to so many places. I can't fix that easily. Let it be.
    7qxiwkf
  • Fix Python extractor. Some json files (at this moment items/software.json and melee.json) have special value in field "name_plural". It's "none". Extractor does't know about this and write this value literally. I fix that. Now it knows what to do with "none" value.
    t1xamhm

~3-5h to fix of ten strings :/

@BevapDin

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2015

Fix Python extractor. Some json files (at this moment items/software.json and melee.json) have special value in field "name_plural". It's "none". Extractor does't know about this and write this value literally. I fix that. Now it knows what to do with "none" value.

It's not really special, you may change it in the JSON if it bothers. It's just that things don't appear in plural, or at least there should never be a need from them. Software: there may several USB sticks, but each contains one software item. There is one nearby fire required for crafting, several fires are not even supported in the code. The "none" is more a placeholder because there is no "fires" or "hackPROs" etc.

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2015

Yes, i tryed to remove them. But then extractor will add 's' at end of
every item :p
Guess that this is a good workout to handle such items.
11.08.2015 1:14 пользователь "BevapDin" notifications@github.com написал:

Fix Python extractor. Some json files (at this moment items/software.json
and melee.json) have special value in field "name_plural". It's "none".
Extractor does't know about this and write this value literally. I fix
that. Now it knows what to do with "none" value.

It's not really special, you may change it in the JSON if it bothers. It's
just that things don't appear in plural, or at least there should never be
a need from them. Software: there may several USB sticks, but each contains
one software item. There is one nearby fire required for crafting,
several fires are not even supported in the code. The "none" is more a
placeholder because there is no "fires" or "hackPROs" etc.


Reply to this email directly or view it on GitHub
#13240 (comment)
.

Rivet-the-Zombie added a commit that referenced this pull request Aug 11, 2015

@Rivet-the-Zombie Rivet-the-Zombie merged commit 066a15c into CleverRaven:master Aug 11, 2015

1 check passed

default
Details

@VlasovVitaly VlasovVitaly deleted the VlasovVitaly:translation-fixes-and-update branch Aug 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.