Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExplosion tile error fix for MShock Modded #13251
Conversation
This comment has been minimized.
This comment has been minimized.
|
So, you've used the very same tile that is already used by standard sized explosion for the weak and medium explosions as well? That pretty much defies the whole purpose of #12767, which was to add graded tiles (as in: different tiles for different explosion strength). Now it's just the same as before.
Would you (or any other tileset editor) have recognized that there are new tiles to be implemented? Re-using the standard explosion tile would have made that PR completely pointless. After all, the purpose of the "no-tile" tile is to inform the player/viewer that the tileset is missing something. |
This comment has been minimized.
This comment has been minimized.
|
Hmm. Very well then, I'll undo the change for all tilesets except MShock Modded. @_@ EDIT: Though as mentioned on the issue page for this, I don't know if any of the tileset authors besides Chezzo and I are active, so these could go unfixed for a long time. |
added some commits
Aug 12, 2015
chaosvolt
changed the title
Explosion tile error fix
Explosion tile error fix for MShock Modded
Aug 12, 2015
kevingranade
self-assigned this
Aug 13, 2015
kevingranade
merged commit 2ef81ab
into
CleverRaven:master
Aug 13, 2015
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thank you for the merge. |
chaosvolt commentedAug 12, 2015
Fix for #13250
Someone decided that having the new forms of explosion animation depicted as "no tile" orbs was better than just re-using the existing sprite assignments for the older explosion animation.
As Chezzo is just about the only other one of us tileset authors still active lately, I'm waiting for his permission before adding this to the Chesthole tilesets, but took the liberty of doing this to the other tilests where feasible.
RetsoASCII was left alone due to lack of an existing sprite assignment for explosions, and RetroDays Iso was left alone due to maddening format making it hard to tell whether adding this would break anything.