Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosion tile error fix for MShock Modded #13251

Merged
merged 3 commits into from Aug 13, 2015

Conversation

Projects
None yet
3 participants
@chaosvolt
Copy link
Contributor

commented Aug 12, 2015

Fix for #13250

Someone decided that having the new forms of explosion animation depicted as "no tile" orbs was better than just re-using the existing sprite assignments for the older explosion animation.

As Chezzo is just about the only other one of us tileset authors still active lately, I'm waiting for his permission before adding this to the Chesthole tilesets, but took the liberty of doing this to the other tilests where feasible.

RetsoASCII was left alone due to lack of an existing sprite assignment for explosions, and RetroDays Iso was left alone due to maddening format making it hard to tell whether adding this would break anything.

chaosvolt
Explosion tile error fix
Someone decided that having the new forms of explosion animation
depicted as "no tile" orbs was better than just re-using the existing
sprite assignments for the older explosion animation.

As Chezzo is just about the only other one of us tileset authors still
active lately, I'm waiting for his permission before adding this to the
Chesthole tilesets, but took the liberty of doing this to the other
tilests where feasible.

RetsoASCII was left alone due to lack of an existing sprite assignment
for explosions, and RetroDays Iso was left alone due to maddening format
making it hard to tell whether adding this would break anything.
@BevapDin

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2015

So, you've used the very same tile that is already used by standard sized explosion for the weak and medium explosions as well? That pretty much defies the whole purpose of #12767, which was to add graded tiles (as in: different tiles for different explosion strength). Now it's just the same as before.

Someone decided that having the new forms of explosion animation depicted as "no tile" orbs was better than just re-using the existing sprite assignments for the older explosion animation.

Would you (or any other tileset editor) have recognized that there are new tiles to be implemented? Re-using the standard explosion tile would have made that PR completely pointless. After all, the purpose of the "no-tile" tile is to inform the player/viewer that the tileset is missing something.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2015

Hmm. Very well then, I'll undo the change for all tilesets except MShock Modded. @_@

EDIT: Though as mentioned on the issue page for this, I don't know if any of the tileset authors besides Chezzo and I are active, so these could go unfixed for a long time.

chaosvolt added some commits Aug 12, 2015

chaosvolt
Revert "Explosion tile error fix"
This reverts commit b63fda8.
chaosvolt
Just the fix for MShock Modded
1. I can opt to add different sprites for the grades of explosion later
on, for now just want to get the notile orbs to stop eating my
explosions. ;_;

@chaosvolt chaosvolt changed the title Explosion tile error fix Explosion tile error fix for MShock Modded Aug 12, 2015

@kevingranade kevingranade self-assigned this Aug 13, 2015

@kevingranade kevingranade merged commit 2ef81ab into CleverRaven:master Aug 13, 2015

1 check passed

default
Details
@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2015

Thank you for the merge.

@chaosvolt chaosvolt deleted the chaosvolt:explosion-tile-assignment branch Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.