Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehicle direction indicator in tiles mode. #13275

Merged

Conversation

Projects
None yet
4 participants
@kevingranade
Copy link
Member

commented Aug 14, 2015

Fixes #13269

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2015

Yay. o3o

EDIT: And just to make sure, what will the tile ID for it be? I'm guessing it's "cursor" from the look of it.

@BevapDin

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2015

@chaosvolt Yes, that's it.

@kevingranade Any reasons why the logic to check for options and valid vehicle is duplicated? It could go into get_veh_dir_indicator_location, it could return tripoint_min or g->u.pos() when no pointer should be drawn.

@drbig

This comment has been minimized.

Copy link
Member

commented Aug 14, 2015

I concur with BevapDin on having the logic checks in one place only.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2015

Curses, merge conflicts.

@kevingranade

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2015

Yea that's superior, will do.

@kevingranade

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2015

@chaosvolt That was one question I had, as a tileset author would you rather it be the same as the look around and aming cursor, or different?

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2015

Sprite-wise I could just use the look/aim cursor, or add a separate sprite that's the same in a different color.

I'm guessing that getting the game to cite the tile_config entity for aim/look would be easier? That seems fine, yes.

@kevingranade kevingranade force-pushed the kevingranade:tiled-vehicle-facing-indicator branch 2 times, most recently to 4fc3357 Aug 15, 2015

@kevingranade

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2015

Implemented @BevapDin's suggestion, and leaving it using "cursor" for now.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2015

That should work quite well, yes. For me at least, hopefully other active tileset authors are fine with it that way.

However it works out, at least it'll be well-timed if that changes, since I'm steadily working on another tileset update. I should probably be a bit more quick about it though, since accounting for a terrain item I added recently is on my to-do list. XP

@BevapDin BevapDin self-assigned this Aug 15, 2015

BevapDin added a commit that referenced this pull request Aug 15, 2015

Merge pull request #13275 from kevingranade/tiled-vehicle-facing-indi…
…cator

Add vehicle direction indicator in tiles mode.

@BevapDin BevapDin merged commit 663b0a7 into CleverRaven:master Aug 15, 2015

1 check passed

default
Details

@kevingranade kevingranade deleted the kevingranade:tiled-vehicle-facing-indicator branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.