Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upThis makes the opening of a gate an activity, so that it will be interruptable. #13466
Conversation
This comment has been minimized.
This comment has been minimized.
|
This is great! |
This comment has been minimized.
This comment has been minimized.
|
I think I see where you're coming from, cancelling after the door opens
could be problematic. One thing that comes to mind is changing the
door/gate/whatever to a 'half open gate' half way through the activity that
allows vision and movement, but counts as difficult terrain. Obviously
that's a whole new feature and isn't necessary for this pr.
|
Rivet-the-Zombie
self-assigned this
Sep 1, 2015
Rivet-the-Zombie
added a commit
that referenced
this pull request
Sep 1, 2015
Rivet-the-Zombie
merged commit 1cad147
into
CleverRaven:master
Sep 1, 2015
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
This seems like probably the best thing to do IMO. |
Leland
referenced this pull request
Jan 23, 2017
Closed
Using a winch lets the door open (and Zed in) far before you're "finished" using it. #11975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jcd000 commentedAug 31, 2015
The side-effect is that any monster beyond the gate will only see the player after the gate is opened, not during. This is because only when the activity ends, the gate is opened. There may be a way to change this to the old behaviour if:
I am against this route however.
This handles issue #11975 and the following forum topic: http://smf.cataclysmdda.com/index.php?topic=11151.0