Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This makes the opening of a gate an activity, so that it will be interruptable. #13466

Merged
merged 1 commit into from Sep 1, 2015

Conversation

Projects
None yet
4 participants
@jcd000
Copy link
Contributor

commented Aug 31, 2015

The side-effect is that any monster beyond the gate will only see the player after the gate is opened, not during. This is because only when the activity ends, the gate is opened. There may be a way to change this to the old behaviour if:

  1. The gate is opened immediately (or after, say, half the time needed to really open it)
  2. A cancellation of the activity results in the gate automatically closing.
    I am against this route however.

This handles issue #11975 and the following forum topic: http://smf.cataclysmdda.com/index.php?topic=11151.0

This makes the opening of a gate an activity, so that it will be
interruptable when danger looms.
The side-effect is that any monster *beyond* the gate will only see the
player after the gate is opened, not during.
This is because only when the activity ends, the gate is opened. There
may be a way to change this to the old behaviour if:
1. The gate is opened immediately (or after, say, half the time needed
to really open it)
2. A cancellation of the activity results in the gate automatically
closing

I am against this route however.
@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Aug 31, 2015

This is great!

@kevingranade

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

@Rivet-the-Zombie Rivet-the-Zombie self-assigned this Sep 1, 2015

Rivet-the-Zombie added a commit that referenced this pull request Sep 1, 2015

Merge pull request #13466 from jcd000/open_gate_is_activity
This makes the opening of a gate an activity, so that it will be interruptable.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 1cad147 into CleverRaven:master Sep 1, 2015

1 check passed

default
Details
@i2amroy

This comment has been minimized.

Copy link
Member

commented Sep 1, 2015

One thing that comes to mind is changing the
door/gate/whatever to a 'half open gate' half way through the activity that
allows vision and movement, but counts as difficult terrain. Obviously
that's a whole new feature and isn't necessary for this pr.

This seems like probably the best thing to do IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.