Boat mod changes

[chaosvolt]

I would hope that my proposed changes prove acceptable overall. Mostly a few alterations to account for vehicle part flags and other things that presumably did not exist when this mod was introduced.

1. Changes boat boards to be nailable. Made of wood, so...
2. Changes oars to use no tools for construction. If we had some implied MOUNTING for the oars it would make sense to need a tool, but figuring out how to row a boat shouldn't need the magic of welding.
3. Changed hand paddles to return splinters when destroyed, due to being craftable from wood.

[Coolthulhu]

Giving controls to paddles alone is not OK:

• Activating headlights with paddles
• Aiming turrets with paddles
• Activating a reactor with paddles

You'd need to add a second tag, like "CONTROLS_SIMPLE" and implement it in vehicle.cpp by making it limit the number of options only to mounting player there and using muscle engines. Not the easiest job.

[chaosvolt]

Hmm. True, it would be rather absurd to turn on headlights by presumably smacking them with paddles. If we did have a simplified controls option, giving them to hand rims and foot pedals would also be a good idea.

[chaosvolt]

Now...hmm. Looking at vehicle.cpp. It may or may not at least be possible to restrict the number of actions muscle-powered controls allow.

enum vehicle_controls {
 toggle_cruise_control,
 toggle_lights,
 toggle_overhead_lights,
 toggle_dome_lights,
 toggle_aisle_lights,
 toggle_turrets,
 toggle_stereo,
 toggle_tracker,
 activate_horn,
 release_control,
 control_cancel,
 convert_vehicle,
 toggle_reactor,
 toggle_engine,
 toggle_fridge,
 toggle_recharger,
 cont_engines,
 try_disarm_alarm,
 trigger_alarm,
 toggle_doors,
 cont_turrets,
 manual_fire,
 toggle_camera,
 release_remote_control,
 toggle_chimes,
 toggle_scoop
};

I am assuming an alternative version of this list could be made, but associating it with a second flag I'm unsure about. Even then I'm guessing that we don't yet have a way to separate powered engines and muscle engines, for the sake of ensuring you can't run an electric motor by waving oars at it suggestively.

However, with hand paddles themselves counting as engines, that issue wouldn't be very visible. I could've sworn last time I tried to slap an engine on a canoe, it wouldn't even let me attempt to.

[kevingranade]

Probably what we'd want here is to have one flag, 'STEERING' or similar, and another one, 'ELECTRONICS_CONTROL' or similar, and the existing controls get both.

[chaosvolt]

Ah, that would be useful. For now though, I would hope the remaining changes are acceptable.