Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tanto tweak and more sheath lunacy #13614

Merged
merged 4 commits into from Sep 21, 2015

Conversation

Reviewers
No reviews
Assignees

@Coolthulhu Coolthulhu

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@chaosvolt @narc0tiq @Rivet-the-Zombie @kevingranade @Coolthulhu
@chaosvolt
Copy link
Contributor

commented Sep 20, 2015

The PR changing some knives ( #13391 ) has had a few...fun consequences, partly due to poor documentation and warning of this change. The survival knife in particular has caused people to mistake it for a bug both here ( #13427 ) and on the forums ( http://smf.cataclysmdda.com/index.php?topic=11291.0 ).

  1. Made the Rivtech knife use a scabbard instead of a sheath. SOMEONE forgot it has the same volume as the tanto. Er, the same volume before...
  2. Reduced the tanto's volume down to 2 and gave it sheath_knife again.
  3. Updated the descriptions of survival knife and Rivtech's knife to mention being unsheathable. Seeing as others have mistaken this change for a bug and complained about it at least twice already, not giving the player some assurance that it's a feature is a Bad Idea.
Chaosvolt
Tanto tweak and more sheath lunacy 
1. Made the Rivtech knife use a scabbard instead of a sheath. SOMEONE
forgot it has the same volume as the tanto. Er, the same volume
before...
2. Bumped the tanto's volume down to 2 and gave it sheath_knife again.
3. Updated the descriptions of survival knife and Rivtech's knife to
mention being unsheathable. Seeing as others have mistaken this change
for a bug and complained about it at least twice already, not giving the
player some assurance that it's a feature is a Bad Idea.
Loading status checks…
27156bd
data/json/items/tools.json Outdated
@@ -8589,10 +8589,10 @@
"color": "dark_gray",
"name": "survival knife",
"name_plural": "survival knives",
"description": "This massive combat knife features a hollow handle with a compass built into the pommel and a row of fearsome looking saw teeth along the back of its blade.",
"description": "This massive combat knife features a hollow handle with a compass built into the pommel and a row of fearsome looking saw teeth along the back of its blade. Being a Bowie knife on steroids, it is too large for most sheaths.",

This comment has been minimized.

Sign in to view
Copy link
@Coolthulhu

Coolthulhu Sep 20, 2015

Contributor

That "combat knife" part could be changed too. It is quite poor when it comes to actually killing stuff.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 20, 2015

Maybe. We could describe it as a Bowie knife in the first sentence, I'll want to change the "you can't sheath this" message to avoid repetitiveness. XP
Chaosvolt
Survival knife description tweak 
1. Changed reference to it being a "combat" knife to instead reference what style of knife it's most likely based off of, at Coolthulhu's suggestion. Cue a similar tweak to the "no sheathing for you" message.
Loading status checks…
e9c9b91
@narc0tiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 21, 2015

Or just "This massive knife features...".

On Mon, Sep 21, 2015 at 2:20 AM, Chaosvolt notifications@github.com wrote:

Maybe. We could describe it as a Bowie knife in the first sentence, I'll
want to change the "you can't sheath this" message to avoid repetitiveness.
XP

—
Reply to this email directly or view it on GitHub
#13614 (comment)
.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 21, 2015

Either way works, hmm. o.o
@Rivet-the-Zombie

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 21, 2015

If we're dividing them like this, then we really ought to have options for small sheath, large sheath, and scabbard.

It's ridiculous that you'd need a full-sized scabbard for any knife.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 21, 2015

That would be nice, yes. That might be beyond the scope of this PR, which is simply cleaning up an inconsistency, fixing tantos via the other available solution, and giving the player more feedback about how the knives work with the current system.
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 21, 2015

Calling it a Bowie knife doesn't clarify anything, if you want to emphasize that it's large, just call it large. (which I note it already said, what's the point of calling it a Bowie?)
I'm very against annotating the descriptions with "this item does or does not work in some specific way." That's a very over-specific thing to put in the description.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 21, 2015

Hmm. Removing the Bowie part, sure.

NOT including some mention of it not working with sheaths, when it seems logical at first glance to have it fit in a sheath, when it used to fit in a sheath, AND after two separate complaints have been raised in the erroneous belief that it's a bug, doesn't seem as sensible to me.
Chaosvolt
Description retweak again 
1. Nope, no Bowie for us then. :v
Loading status checks…
92e4454
@kevingranade

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 21, 2015

Just because someone is complaining doesn't mean they have a valid point. If it needs clarification, it needs clarification in the sheath, not in every bladed weapon. Or worse, in an arbitrary subset of the bladed weapons.
Alternately, we can revisit what should and should not fit in a knife sheath.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 21, 2015

Hmm. Could put the disclaimer in the sheath description I guess. Some form of clarification is needed though, regardless of where it occurs.
chaosvolt
[Tweaking Intensifies] 
1. Removed disclaimers from survival knife and Rivtech's ginsu knife.
=w=
Loading status checks…
630b012

@Coolthulhu Coolthulhu self-assigned this Sep 21, 2015

Coolthulhu added a commit that referenced this pull request Sep 21, 2015

@Coolthulhu
Merge pull request #13614 from chaosvolt/knife-unborking 
Tanto tweak and more sheath lunacy
3c46c32

@Coolthulhu Coolthulhu merged commit 3c46c32 into CleverRaven:master Sep 21, 2015
1 check passed

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
@chaosvolt

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 21, 2015

And thank you for the merge.

@chaosvolt chaosvolt deleted the chaosvolt:knife-unborking branch Sep 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.