Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgettext'ing orange as color in item.cpp #13740

Merged
merged 2 commits into from Oct 18, 2015

Conversation

Projects
None yet
4 participants
@Night-Pryanik
Copy link
Member

commented Oct 11, 2015

To distinguish it from orange as fruit.

Pgettext'ing orange as color in item.cpp
To distinguish from orange as fruit.
@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2015

Silly Night, the color orange does not exist in Cataclysm. ;w;

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2015

Silly Night, the color orange does not exist in Cataclysm. ;w;

Uhhhm, what?
1111111111111111111111

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2015

I know. I was making fun of the fact that the actual color itself is not used by the game's palette. >.>

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2015

Oh, it seems that my sense of humor deactivates after someone calling me "silly" for nothing.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2015

._.

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

Can you replace "orange as color" -> "color". This makes more good sense, cuz contexts made for grouping.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2015

No probs.

@chaosvolt

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

I'm now tempted to make orange exist in-game. <.<

@VlasovVitaly

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2015

Ready for merge, guess.

Rivet-the-Zombie added a commit that referenced this pull request Oct 18, 2015

Merge pull request #13740 from Night-Pryanik/patch-2
Pgettext'ing orange as color in item.cpp

@Rivet-the-Zombie Rivet-the-Zombie merged commit 4a401da into CleverRaven:master Oct 18, 2015

1 check passed

default
Details

@Night-Pryanik Night-Pryanik deleted the Night-Pryanik:patch-2 branch Oct 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.