Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upPgettext'ing orange as color in item.cpp #13740
Conversation
This comment has been minimized.
This comment has been minimized.
|
Silly Night, the color orange does not exist in Cataclysm. ;w; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I know. I was making fun of the fact that the actual color itself is not used by the game's palette. >.> |
This comment has been minimized.
This comment has been minimized.
|
Oh, it seems that my sense of humor deactivates after someone calling me "silly" for nothing. |
This comment has been minimized.
This comment has been minimized.
|
._. |
This comment has been minimized.
This comment has been minimized.
|
Can you replace "orange as color" -> "color". This makes more good sense, cuz contexts made for grouping. |
This comment has been minimized.
This comment has been minimized.
|
No probs. |
This comment has been minimized.
This comment has been minimized.
|
I'm now tempted to make orange exist in-game. <.< |
This comment has been minimized.
This comment has been minimized.
|
Ready for merge, guess. |
Rivet-the-Zombie
added a commit
that referenced
this pull request
Oct 18, 2015
Rivet-the-Zombie
merged commit 4a401da
into
CleverRaven:master
Oct 18, 2015
1 check passed
default
Details
Night-Pryanik
deleted the
Night-Pryanik:patch-2
branch
Oct 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.

Night-Pryanik commentedOct 11, 2015
To distinguish it from orange as fruit.