Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upLava vents spawn chunks of sulfur #13934
Conversation
jokermatt999
added some commits
Nov 6, 2015
Coolthulhu
reviewed
Nov 7, 2015
| @@ -13947,6 +13947,9 @@ void mx_fumarole(map &m, const tripoint &) | |||
| std::vector<point> fumarole = line_to(x1, y1, x2, y2, 0); | |||
| for (auto &i : fumarole) { | |||
| m.ter_set(i.x, i.y, t_lava); | |||
| if (one_in(10)){ | |||
| m.spawn_item(i.x-1, i.y-1, "chunk_sulfur"); | |||
This comment has been minimized.
This comment has been minimized.
Coolthulhu
Nov 7, 2015
Contributor
Code quality: spacing (if( x ) { etc., not if (x){)
This could use a random position roll instead of always putting it in the same relative spot.
This comment has been minimized.
This comment has been minimized.
|
Out of curiosity, why the extra item? The recipe is relatively easy, auto-learned and only requires a rock. It's no obstruction at all. Can one even use the resulting sulfur without a fabrication skill of at least 1? (That would be the only situation where it actually matters.) Or is this a realism thing? (I've never been near lava.) |
This comment has been minimized.
This comment has been minimized.
|
Partly realism, partly a hacky-fix for sulfur spawning in canvas bags. |
This comment has been minimized.
This comment has been minimized.
That would make a nice bug. However, for future reference: one could use m.spawn_item( some_point_or_x_and_y, "sulfur", 1, rng( 1, 100 ) ); |
This comment has been minimized.
This comment has been minimized.
|
Good to know, thank you! |
Coolthulhu
reviewed
Nov 9, 2015
| "name_plural" : "chunks of sulfur", | ||
| "symbol" : "*", | ||
| "color" : "yellow", | ||
| "description" : "A large chunk of pure sulfur. Break it up to use it.", |
This comment has been minimized.
This comment has been minimized.
jokermatt999 commentedNov 7, 2015
Fumaroles/lava vents now occasionally spawn large chunks of sulfur nearby, which can be broken down into sulfur.