Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trig dist aiming fix #13950

Merged
merged 2 commits into from Nov 9, 2015

Conversation

Reviewers
No reviews
Assignees

@Coolthulhu Coolthulhu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kevingranade @Coolthulhu
@kevingranade
Copy link
Member

commented Nov 8, 2015

As reported by Marte in the forums: http://smf.cataclysmdda.com/index.php?topic=11553.0
Throwing very large items with an effective range of 1 would break the aiming menu in circular distance mode.

  1. Only throwing orthogonally is allowed, while technically correct, it's nicer to put in a minimum that allows throwing at all adjacent squares, so I did that.
  2. Moving the cursor to a diagonally adjacent square in this situation would cause the tiles rendering code to crash due to not properly handling 0-length lines.

@Coolthulhu Coolthulhu self-assigned this Nov 9, 2015

Coolthulhu added a commit that referenced this pull request Nov 9, 2015

@Coolthulhu
Merge pull request #13950 from kevingranade/trig-dist-aiming-fix 
Trig dist aiming fix
69e2aed

@Coolthulhu Coolthulhu merged commit 69e2aed into CleverRaven:master Nov 9, 2015
1 check passed

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@kevingranade kevingranade deleted the kevingranade:trig-dist-aiming-fix branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.