Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds burglar profession and swag bag #13977

Merged
merged 3 commits into from Dec 13, 2015

Conversation

Projects
None yet
3 participants
@chaosvolt
Copy link
Contributor

commented Nov 11, 2015

An idea I had in the past, decided to PR it. Point cost and whether to give any skills might need to be messed with, as well as whether to bother with the added item versus handing the profession a duffel bag.

  • Burglar profession, with a basic array of entry tools and a stereotypical bag for loot.
  • Added burglar to a few of the scenarios.
  • Added ability to re-purpose large canvas sacks. If it weren't for the potential oddity of storing loot in bags full of powder, I would simply give regular canvas bags armor data.
chaosvolt
Adds burglar profession and swag bag
* Burglar profession, with a basic array of entry tools and a
stereotypical bag for loot.
* Added burglar to a few of the scenarios.
* Added ability to re-purpose large canvas sacks. If it weren't for the
potential oddity of storing loot in bags full of powder, I would simply
give regular canvas bags armor data.
@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2015

Thank you. Also at least should add to the uses of the humble canvas sack once it's emptied. I would've added a small version, except the small canvas sack has an immensely tiny storage capacity.

As for the profession itself, dunno yet if its point cost would warrant any starting skills, or whether it's fine as-is.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2015

Hnng. I hunger for feedback. ;w;

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2015

Still hoping for feedback from @Coolthulhu or @Rivet-the-Zombie on the point cost, possible skill/item changes, etc. I suspect this PR got overlooked by the last couple waves of PRs that were examined. -w-

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Dec 9, 2015

Yeah, I missed this one. Sorry about that!

I'd say the point cost is a bit low, considering how much handy stuff this profession starts with. Maybe raise it by a point or two?

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2015

Ah, it's fine. ^^

And might be good to raise it by a point, sure.

Chaosvolt
Raises point cost from 2 to 3
Can always bump it up even further if needed.
"description" : "A large canvas sack, re-purposed for makeshift storage. Goes well with a striped shirt and a domino mask.",
"price" : 0,
"material" : "cotton",
"volume" : 1,

This comment has been minimized.

Copy link
@Coolthulhu

Coolthulhu Dec 9, 2015

Contributor

Just 1?

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2015

Let me see, I suspect I based the swag bag's volume off of the item used to make it. If not, then it likely was an oversight when I edited whatever I copied the initial item off of. @_@

EDIT: Oversight it is, bag_canvas has a volume of 4. Doh.

Chaosvolt
Fixed swag bag's volume
Seems I forgot that when I was altering the properties to match that of the canvas bag.

Rivet-the-Zombie added a commit that referenced this pull request Dec 13, 2015

Merge pull request #13977 from chaosvolt/burglar-addition
Adds burglar profession and swag bag

@Rivet-the-Zombie Rivet-the-Zombie merged commit 7f0e54d into CleverRaven:master Dec 13, 2015

1 check passed

default
Details

@chaosvolt chaosvolt deleted the chaosvolt:burglar-addition branch Dec 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.