Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMove my cola dang it! #14110
Conversation
This comment has been minimized.
This comment has been minimized.
|
Does it still prevent you from moving part of the contents of a container that can't be resealed? |
This comment has been minimized.
This comment has been minimized.
|
In a sense that only container that spawns with liquid and is not resealable is aluminium can. Or I wasn't able to find one. Anyway! So that's why it's there... Annoying cheaters, that is why we can't have nice things. Switching to [WIP] until I fix it. Thanks for letting me know. Though I will have to change definition of one container to actually test it. Or change whisky to come in the can instead of bottle. |
Robik81
changed the title
Move my cola dang it!
[WIP] Move my cola dang it!
Nov 21, 2015
Robik81
added some commits
Nov 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Fixed. Can be tested by spawning test_whiskey item in a container via debug menu. test_whiskey and test_bottle_glass are for testing only and should not be merged |
Robik81
changed the title
[WIP] Move my cola dang it!
Move my cola dang it!
Nov 21, 2015
This comment has been minimized.
This comment has been minimized.
|
The reason it's asking for watertightness is that you're going to throw that container in your pack and if it isn't watertight it's going to spill. |
This comment has been minimized.
This comment has been minimized.
|
Oh yea, and you get to field the complaints about people's drinks spilling :D |
This comment has been minimized.
This comment has been minimized.
|
@kevingranade Yeah, I can see why letting people only partially unload non-resealable containers is not a brilliant idea. But I already fixed it by checking that 'move' command only works if you empty the source container entirely. Target container still have to be resealable, no change here. The only purpose of this PR is to allow moving liquids from factory sealed containers (aluminum cans) into different container without having to resort to Unload command. |
Robik81 commentedNov 21, 2015
Removing unnecessary watertight check from SOURCE container.
What the...

That's better!
