Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move my cola dang it! #14110

Merged
merged 4 commits into from Nov 30, 2015

Conversation

Projects
None yet
3 participants
@Robik81
Copy link
Contributor

commented Nov 21, 2015

Removing unnecessary watertight check from SOURCE container.

What the...
moveitfromthecan_01

That's better!
moveitfromthecan_02

@CIB

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2015

Does it still prevent you from moving part of the contents of a container that can't be resealed?

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2015

In a sense that only container that spawns with liquid and is not resealable is aluminium can. Or I wasn't able to find one.

Anyway! So that's why it's there... Annoying cheaters, that is why we can't have nice things.

Switching to [WIP] until I fix it. Thanks for letting me know. Though I will have to change definition of one container to actually test it. Or change whisky to come in the can instead of bottle.

@Robik81 Robik81 changed the title Move my cola dang it! [WIP] Move my cola dang it! Nov 21, 2015

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2015

Fixed.

Can be tested by spawning test_whiskey item in a container via debug menu.

test_whiskey and test_bottle_glass are for testing only and should not be merged

@Robik81 Robik81 changed the title [WIP] Move my cola dang it! Move my cola dang it! Nov 21, 2015

@kevingranade

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

The reason it's asking for watertightness is that you're going to throw that container in your pack and if it isn't watertight it's going to spill.
If you want to enable putting liquids in non-resealable containers you're going to need to add support for having them spill when placed in the inventory, but not when held or placed on the ground.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Nov 27, 2015

Oh yea, and you get to field the complaints about people's drinks spilling :D

@Robik81

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2015

@kevingranade Yeah, I can see why letting people only partially unload non-resealable containers is not a brilliant idea. But I already fixed it by checking that 'move' command only works if you empty the source container entirely. Target container still have to be resealable, no change here.

The only purpose of this PR is to allow moving liquids from factory sealed containers (aluminum cans) into different container without having to resort to Unload command.

@kevingranade kevingranade merged commit d0fc69d into CleverRaven:master Nov 30, 2015

1 check passed

default
Details

@Robik81 Robik81 deleted the Robik81:MoveItFromTheCan branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.