Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[CR] Fix for flickering in SDL version, v3 #14221
Conversation
DanmakuDan
referenced this pull request
Nov 29, 2015
Closed
[CR] Fix for flickering in SDL version, v2 #14164
This comment has been minimized.
This comment has been minimized.
|
The ride never ends. ;w; |
kevingranade
merged commit c4a30f8
into
CleverRaven:master
Nov 30, 2015
1 check passed
default
Details
This comment has been minimized.
This comment has been minimized.
|
Ah, nice. Will have to update soon to test this. |
This comment has been minimized.
This comment has been minimized.
|
Well...hmm. The good news is that fixed the flickering. The bad news is...well, damn near everything I started doing after verifying that basic menu flickering was fixed. ._. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DanmakuDan commentedNov 29, 2015
The last one (#14164) became unmergable, included in this one are the minimum group of changes for fixing flickering in SDL versions.
game::drawhandles most original missing cases (sleeping/waiting for certain actions).output.cpp ::popuphandles popups that didn't show up in certain cases (loading game, save % text).animation.cpp ::draw_animation_delayhandles animation frames like it did earlier.