Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically rotate movement in isometric mode #14395

Merged
merged 4 commits into from Dec 14, 2015

Conversation

Projects
None yet
3 participants
@sparr
Copy link
Member

commented Dec 12, 2015

The new option affects player movement and remote control non-vehicle driving, so an action mapped to "move north" will actually move northeast (which is the visual "up" direction in isometric mode).

I put this option on the Graphics tab because it's linked to the graphics mode.

I added the rotation in the following places:

game::rcdrive is used for driving rc cars (the item, not rc vehicles)

game::plmove is used for walking around

get_direction used for ... nothing. So I removed it. I suspect this predates inputcontext

input_context::get_direction is used for many things, some of which are non-isometric even when the game is using isometric tiles. I've added input_context.set_iso() to tell an input_context that it should obey the rotation rule. I tried to set this on all the appropriate contexts.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 12, 2015

Why's it an option? AFAICT the un-rotated movement in iso-like mode is just bad, so we should just do this if you're using iso tiles and it's better.

@sparr

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2015

I can definitely make this not-optional.

At the moment, playing in tiles mode is very hard for me due to computer slowness, so this patch needs some playtesting. Once someone(s) says it's OK, I'll push a change to make it non-optional for you to merge.

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2015

No reason for this to be optional, as Kevin says.

@sparr

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2015

ok. I haven't found an inputcontext where this doesn't work. just pushed the patch to make it non-optional. I'll merge this if no one tests/complains soon.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Dec 13, 2015

@sparr

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2015

@kevingranade roger that

@sparr sparr changed the title Add option to automatically rotate movement in isometric mode Automatically rotate movement in isometric mode Dec 14, 2015

@kevingranade kevingranade merged commit 14054bd into CleverRaven:master Dec 14, 2015

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@sparr sparr deleted the sparr:iso_remap_movement branch Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.