Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix "Crash at world load in a freshly unpacked game" #14400
Conversation
BevapDin
added some commits
Dec 12, 2015
This comment has been minimized.
This comment has been minimized.
|
Compiles and resolves #14399 for me |
rluddy
referenced this pull request
Dec 12, 2015
Closed
Fixed mapgen crash from terrain/furniture mixup #14407
This comment has been minimized.
This comment has been minimized.
|
Many persons are awaiting this fix in experimental judging by the amount of duplicate issues on github, forum posts and reddit posts. |
sparr
added a commit
that referenced
this pull request
Dec 13, 2015
sparr
merged commit 1f7d1bc
into
CleverRaven:master
Dec 13, 2015
1 check passed
default
Details
BevapDin
deleted the
BevapDin:wyk
branch
Dec 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedDec 12, 2015
Fixes #14399, there was still some code that trows
std::stringand not a proper exception, those thrown strings don't get caught and make the game crash. Now it uses proper error reporting via the JSON classes, which throws a proper exception.The exception is triggered by the teashop which apparently tries to place furniture (f_mutpoppy), but says it wants to place terrain. That does not work as the game tries to place a terrain named "f_mutpoppy", but there is no such terrain.