Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upProvide more ammo accessors #14837
Conversation
mugling
added some commits
Jan 11, 2016
This comment has been minimized.
This comment has been minimized.
|
I'm not sure if that is a step towards ammo overlap (see .38 Special plus .357 Magnum, .410 shotshells plus .45 Colt, etc) or something with different applications. |
This comment has been minimized.
This comment has been minimized.
|
No, its just the two accessor functions extracted from #14799. They are intended to replace I'm going to work sequentially through consumers of |
This comment has been minimized.
This comment has been minimized.
|
That would be failure to read on my part, as the original post states that this is tied to the shift towards magazines, Doh. >.< |
mugling commentedJan 13, 2016
ammo_data()andammo_current()from #14799 excluding handling of magazinesget_curammo_id()which is trivially replaced byammo_current()item::weight()to use new accessors plus simplify logic and astyleFurther PR's will extend usage of these accessors and ultimately deprecate
get_curammo. When we then merge the magazine type all functions using these accessors will be aware of magazines.