Mutant wildlife expansions: Spiders and snakes

[chaosvolt]

As mentioned, two ideas I'd mentioned as minor ways to diversify a couple of areas other than the typical city horde that gets the most Fun.

• Giant cellar spiders. If normal cellar spiders existed in Cataclysm, they would be adorable. Giant ones, not so much. Meant to be fragile-speedster types relative to giant black widows.
• Spiderling variant of giant cellar spiders. Shows up as the egg sack alternative for cellar spider cella-erm, basements.
• Giant rattlesnakes. Hiss...hiss...this is snek. Somewhat higher aggression, but hopefully not severely tougher than normal ones.
• Eggsacks for giant cellar spiders.

[Rivet-the-Zombie]

Neat!

[chaosvolt]

Just a few minor mistakes to sort out first. :V

[chaosvolt]

Swiggity swooty. Just minor forgotten things, this time I didn't make the source code self-destruct. o3o

[Coolthulhu]

Is that entire block a total copy+paste of the block above?
If so, you should just roll spider and egg type at start of the block (just after } else if( one_in( 150 ) ) {) and then use that.
Like this:

auto spider_type = mon_spider_widow_giant;
auto egg_type = f_egg_sackbw;
if( one_in(2) ) {
    spider_type = mon_spider_cellar_giant;
    egg_type = f_egg_sackcs;
}

Then later in the function, instead of m->add_spawn(mon_spider_cellar_giant, rng(1, 2), i, j); you'd use m->add_spawn(spider_type, rng(1, 2), i, j); and instead of m->furn_set(i, j, f_egg_sackcs); use m->furn_set(i, j, egg_type);

[chaosvolt]

Hmm. That would be more efficient, yes.

[Coolthulhu]

Same for this block.

[Coolthulhu]

Does it work? I can't find the place where egg id is set in mapdata.cpp
Make sure to test it before marking it as ready. As testing mapgen crap is tedious, you can set that spider basement chance to one_in(1) instead of 150, just make sure to revert it at the end.

[chaosvolt]

Ah. Still need to set the path for the compiler on my laptop. I'll set up the changes you suggested, then compile-test spider basements.

EDIT: Compiling, slowly but steadily.

EDIT 2: It's past mapgen_functions.o, so this is good sign.

EDIT 3: Compiled after 20 minutes, yaaay.

[chaosvolt]

Could not find iexamine for the eggsack. Scheisse.

[Coolthulhu]

Try to find how it's done for the other eggsack.
Find where it is referenced in sources. Here's a guide on searching sources:
http://www.wiki.cataclysmdda.com/index.php?title=How_to_search_the_sources

[chaosvolt]

Aye. New problem though.

Got lucky with the first basement I found. It spawned a mixture of giant cellar spiders and black widows.

[Coolthulhu]

Push the changes, I can't see what you did there.
You probably roll spiders per critter rather than per basement.

[chaosvolt]

Ack. Need to re-do it as I'd discarded the changes. Will do so along with fixing eggsacks.

[chaosvolt]

There we go. I might've placed them lower in the function originally, so it SHOULD work in this instance.

Will have to head out soon, but when I'm next on I'll compile again to see if it got fixed.

[chaosvolt]

...did I seriously derp and link to the wrong PR? >_<

[Zireael07]

Wow, cool!

[Rivet-the-Zombie]

Copy+paste error?

[chaosvolt]

Yep. Doh. >.<

[Rivet-the-Zombie]

I think the big snake could be louder when it rattles. What do you think, @chaosvolt?

[chaosvolt]

Hmm, right. How best to add that though? o.o

[Rivet-the-Zombie]

Use the PARROT function instead of the RATTLE one and give it an appropriate entry in the speech.json file - you can adjust the volume in that file at the same time.

I haven't tested this idea; it may not work as described.

[chaosvolt]

Ah right. I'd assumed that the rattle only seems to occur when the player gets close enough though, suggesting it's used like a special attack. Whereas parroting might occur automatically, I think? Unless there's a way to make parrot only occur when close enough.

[Rivet-the-Zombie]

Good point, so let's skip this!

---

This kind of discussion is the sort of silly little stuff that slows good PRs down. Don't sweat the volume; it's good just the way it is now.

[chaosvolt]

Ah, true. Can always be added another day. XP

[chaosvolt]

Meep. And thank you for the merge.

[chaosvolt]

Hmm. Giant rattlesnakes at least seem to steadily aggro if the player lingers. Giant cellar spiders seem to be hopelessly non-aggresive though. They should at least start off neutral but still be able to discourage sticking around, so giving them "PLAYER_CLOSE" as an anger trigger might work.