Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMake Wyrmskin Armor Repairable Again. #15340
Conversation
Malkeus
added some commits
Feb 10, 2016
This comment has been minimized.
This comment has been minimized.
|
Ok, I believe I found the relevant code: |
Malkeus
changed the title
[CR] Make Wyrmskin Armor Repairable Again.
Make Wyrmskin Armor Repairable Again.
Feb 11, 2016
kevingranade
merged commit dcfa9d2
into
CleverRaven:master
Feb 11, 2016
1 check passed
default
Details
Malkeus
deleted the
Malkeus:Wyrmskin_Fix
branch
Feb 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Malkeus commentedFeb 10, 2016
Making it unrepairable wasn't intended, this PR corrects that. I would welcome input on the adjustment to the wyrmskin materials acid_resist to allow the total acid_resist for the armor to remain the same as before.
Are material resistances averaged on dual material items?
Wyrmskin material acid resist is 20 prior to this PR.
Leather material acid resist is 4.
edit: Unrepairable status was noted in the forums: http://smf.cataclysmdda.com/index.php?topic=11013.msg267022#msg267022