Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMove turret monattacks to a json actor #15370
Conversation
Coolthulhu
added some commits
Feb 13, 2016
This comment has been minimized.
This comment has been minimized.
|
Very nice! |
mugling
reviewed
Feb 13, 2016
| { | ||
| "type" : "gun", | ||
| "cooldown" : 2, | ||
| "gun_type" : "hk_mp5", |
This comment has been minimized.
This comment has been minimized.
mugling
Feb 13, 2016
Contributor
This would be an ideal time to define fake_smg in item/gun/fake.json as discussed in #15227
kevingranade
merged commit 94175ff
into
CleverRaven:master
Feb 13, 2016
1 check passed
default
Details
Coolthulhu
deleted the
cataclysmbnteam:generic-turret
branch
Feb 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedFeb 13, 2016
Currently only SMG and antimateriel turrets are converted to the json versions, because assault rifle and frag 'nade functions are used by tankbot and chicken walker. I don't have a good way of invoking jsonized actors from other actors.
Allows setting gun type, ammo type, targeting range, stats and skills for the fake NPC, move cost, laser locking (true/false) and moves wasted on targeting.
Changed antimateriel turret a tiny bit: allowed it to target player at 20 (was 18), stopped it from targeting stuff at range 40 when friendly (lowered to 20, because it required special casing and wasted ammo at that range).
Also fixed a bug that affected turrets for a while: fake NPC stats weren't set up correctly, resulting in larger than expected dispersion for monster and vehicle turrets.