Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMagazines retain an empty ammo item in error #15581
Conversation
mugling
changed the title
Don't retain an empty ammo item in error
Magazines retain an empty ammo item in error
Feb 27, 2016
Coolthulhu
self-assigned this
Feb 27, 2016
Coolthulhu
added a commit
that referenced
this pull request
Feb 27, 2016
Coolthulhu
merged commit b0a3e1e
into
CleverRaven:master
Feb 27, 2016
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mugling commentedFeb 27, 2016
Currently an item with
charges == 0persists in the magazine which results in the magazine havingammo_remaining() == 0butammo_data() != nullptr. A symptom of this is the bug identified by @Firestorm01X2Fixes #15578