Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExplosion code refactor #15640
Conversation
This comment has been minimized.
This comment has been minimized.
|
Nice. I was considering looking into the 40mm ammo and this PR should presumably make that much easier? |
This comment has been minimized.
This comment has been minimized.
|
So here's a little story. Back in the days when I was just starting to mess with Cata I made a PR #8727 where I rebalanced some explosives due to the fact that we don't have vehicle armour. If you are going to overhaul explosions you probably should look at how stats where before that PR. |
This comment has been minimized.
This comment has been minimized.
|
Maybe it's time to move the explosion code into a separate place (namespace? or make it a member of With the additional parameters and return type from @mugling's shrapnel PR, the |
Maeyanie
and others
added some commits
Mar 4, 2016
Coolthulhu
changed the title
[WiP]Custom explosions for items
Explosion code refactor
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
Went this route.
|
Coolthulhu commentedMar 2, 2016
Changed the PR to be more general:
game::explosion( tripoint, explosion_data )- much cleaner than all those arguments. Changed the old explosion function to a be an overload of the 2 argument one.