New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKs Rebalancing Mod: Blobs and zoms #15707

Merged

Coolthulhu merged 27 commits into CleverRaven:master from unknown repository

Mar 11, 2016

Contributor

pisskop commented Mar 8, 2016

The speech files, the stray item additions and item groups. These are the smallest files of the mod, and should have minimal impact on the game if used without the rest of the files.


      PKs Rebalancing Mod P1

The smallest of the files.  Should have minimal impact on play if used as is.

a5f12f4

Contributor

Coolthulhu commented Mar 8, 2016

The individual PRs should be testable. That is, it should be possible to start the game with the mod selected, go through the individual additions and check if none of them are bugged.

That's part of why I advised starting with thematic changes.

Also, there are some tabs left over.

Contributor Author

pisskop commented Mar 8, 2016

:( Several of these are reliant upon the gestault to function without error. For instance the spawn lists rely upon all the creatures in the other files, which rely upon their own files, such as items.

pisskop added some commits Mar 8, 2016


      Deleted ammo

Ammo is for Doom critters

74a7a9c


      deleted Guns

Guns are for Doom Critters

ed3731b


      Deleted Tools

These tools are for Doom critters

b548e77


      Deleted item lists

These are for fungus and doom critters

42c3dc8


      Removed Hellspire

Hellspire is for doom critters; the rest should function in the vanilla game.

0d249d6


      Deleted overmap terrain

Doom critters

c6347a4


      Uploaded Blob and zombies

Should work independent of other files

3cfe535

pisskop changed the title PKs Rebalancing Mod Part1 PKs Rebalancing Mod: Blobs and speech files Mar 8, 2016

pisskop added some commits Mar 8, 2016


      Misnamed folder

ca05b17


      Misnamed folder

3e7ddd2


      Blobs and Zombies

In the correct folder

1614aa2


      wrong folder again

f866bd6


      wrong folder again

280c368


      Added Blob and zombie to proper folder

5ea3be0


      Deleted overmap stuff

Didnt I do this already?

Contributor

Coolthulhu commented Mar 8, 2016

Are the speech files related to zombies? They are like half of the PR, but they seem to be fungal survivor related rather than zombie/blob related. Plus, if the zombies don't use the files, they can't be tested here.

800 lines of a PR is pushing it, 1000+ is too much.

pisskop added some commits Mar 8, 2016


      Deleted Fungus speech

aa6fb51


      Deleted Fungus speech

532874d


      deleted fungus speech


      deleted fungus speech

540b384

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
                    "type" : "bite",

                    "cooldown" : 10,

                    "no_infection_chance" : 20,

                    "min_mul" : 0.5, "//" : "stronger jaws"

Coolthulhu Mar 8, 2016

Contributor

At this point in evolution, regular bite is rather weak. You could buff it by copying the damage structures from (vanilla) feral hunter.

no_infection_chance is negative - the higher it is, the less likely it is to infect.

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
                    "cooldown" : 10

                },

                ["ACID_ACCURATE", 30], ["ACID_BARF", 30], ["GRAB", 20]],

            "special_when_hit":["ACIDSPLASH", 2],

Coolthulhu Mar 8, 2016

Contributor

Just 2 percent?

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
                },

                ["ACID_ACCURATE", 30], ["ACID_BARF", 30], ["GRAB", 20]],

            "special_when_hit":["ACIDSPLASH", 2],

            "description":"Dragging its distended belly with powerful arms, this zomebie's mangled, chunky legs appear to be leaking a flim of acid.  It appears to have poor sight, and might be dangerous to attack.  Then again, it seems to be capable of spitting acid as well.",

Coolthulhu Mar 8, 2016

Contributor

"zomebie"

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
                ["ACID_ACCURATE", 30], ["ACID_BARF", 30], ["GRAB", 20]],

            "special_when_hit":["ACIDSPLASH", 2],

            "description":"Dragging its distended belly with powerful arms, this zomebie's mangled, chunky legs appear to be leaking a flim of acid.  It appears to have poor sight, and might be dangerous to attack.  Then again, it seems to be capable of spitting acid as well.",

            "flags":["ACIDPROOF", "ACID_BLOOD", "ACIDTRAIL", "SEES", "HEARS", "SMELLS", "STUMBLES", "WARM", "BASHES", "GRABS", "POISON", "NO_BREATHE", "REVIVES", "BONES"],

Coolthulhu Mar 8, 2016

Contributor

Acid trail sounds like a perfect way to kill own allies...

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
            "hp":180,

            "death_function":["NORMAL", "BLOBSPLIT"],

            "special_attacks":[["UPGRADE", 30], ["RESURRECT", 30], ["FORMBLOB", 180], ["LONGSWIPE", 10]],

            "description":"Standing with errect back and mocking smile, this graceful zombie appears to actually direct nearby zombies with glares and the twitching of its jagged claws.  Its skin is a revolting shade of pink, and every once in a while it stops what it is doing to excrete a few gooey, animate blobs.",

Coolthulhu Mar 8, 2016

Contributor

"errect"

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
            "hp":666,

            "death_function":["NORMAL"],

            "special_attacks":[["SMASH", 20], ["BIO_OP_TAKEDOWN", 30]],

            "description":"Rumored to be the conjoining of several bodies, the massive Zombie Tank is perhaps the ultimate tool of destruction.  Making up for what it lacks in skill with brutality, it is the demolisions of the zombie scourge.",

Coolthulhu Mar 8, 2016

Contributor

"it is the demolisions of the zombie scourge" - doesn't sound right. "Wrecking ball" maybe? "One-zombie demolitions squad"?

Coolthulhu reviewed Mar 8, 2016

View changes

data/mods/PK_Rebalance v0.75/pk_critter_zombie.json Outdated

  
                    "cooldown" : 30

                },

                ["GRAB_DRAG", 12], ["GRAB", 8], ["STRETCH_ATTACK", 15]],

            "description":"A fetid body with a featureless face that emits a noxious gas of unknown make.  Its skin knots and reforms into putty-like globs as it walks and attacks, and bullets seem to pass through its morphing form.  Upon death its body rapidly deteriorates into a vicous pink sludge reminicent of boomers.",

Coolthulhu Mar 8, 2016

Contributor

"unknown make" -> "unknown makeup", as in chemical makeup.

The description probably shouldn't mention what happens on death. It can warn of it by saying that it stinks like a boomer or occasionally barfs up bile on itself or something like that.


      Updated Zombies

All good suggestions/corrections.

ed27956

pisskop changed the title PKs Rebalancing Mod: Blobs and speech files PKs Rebalancing Mod: Blobs and zoms Mar 8, 2016

Contributor Author

pisskop commented Mar 9, 2016

moving the files from 'v0.75' to a folder that removes the numbers

pisskop added some commits Mar 9, 2016


      moving file

e4e628d


      moving file

46e9b60


      moving file

59b07dd


      moving file

cb176b1


      Moved to new folder name.

pima

945396d

Coolthulhu self-assigned this Mar 9, 2016

Contributor

Coolthulhu commented Mar 10, 2016

Major problems:

There are json errors on world load because of missing evolution groups. You can dummy them out for now or cut out some of the PR to make space for them.

Moderate problems:

The mod is in rebalancing category, but it does much more than just rebalancing existing creatures. Should be in creature mods category.
Comment on mod doesn't mention that it adds new zombie types
The stone slab is added in this PR, but not referenced anywhere in it. Can be cut out for now.

Minor problems (tolerable, don't need to be fixed before merging but would be nice):

The inconsistent indentation (spacing before lines) makes the jsons look ugly
The acid trail zombies are just friendly fire machines - nearly harmless to player, deadly to their own allies
Acid trail zombies look like spitters in console display

Coolthulhu removed their assignment Mar 10, 2016

pisskop added some commits Mar 10, 2016


      Added files via upload

1f150f6


      deleted furiture

53b1b99

Coolthulhu self-assigned this Mar 11, 2016

Coolthulhu added a commit that referenced this pull request Mar 11, 2016


      Merge pull request #15707 from pisskop/master

PKs Rebalancing Mod: Blobs and zoms

ab09bb0

Coolthulhu merged commit `ab09bb0` into CleverRaven:master Mar 11, 2016
1 check passed

1 check passed

default

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.