Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wearing clothing with OVERSIZE flag with footwear #16173

Merged
merged 4 commits into from Apr 13, 2016

Conversation

Projects
None yet
2 participants
@Night-Pryanik
Copy link
Member

commented Apr 12, 2016

We don't have any footwear with BELTED flag (how is this possible anyway?) and also it will allow wearing regular or emergency blanket, for example, on top of footwear, as was discussed in http://smf.cataclysmdda.com/index.php?topic=12375.0.

Allow wearing clothing with OVERSIZE flag with footwear
We don't have any footwear with `BELTED` flag (how is this possible anyway?) and also it will allow wearing regular or emergency blanket, for example, with footwear, as was discussed in http://smf.cataclysmdda.com/index.php?topic=12375.0.
@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2016

Needs not to allow wearing XL boots on top of regular ones.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

Oh, I also overlooked for ankle holster and ankle sheath for BELTED footwear, but they have OVERSIZE flag too, so it's ok, I suppose.
Nevertheless, it seems that XL boots is only one type of actual footwear with OVERSIZE. What should I do with this? Add explicit check for these boots?

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

Or maybe add a check for allowing wearing OVERSIZE boots only with volume, say, more than 20?

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2016

No id hardcoding or volume check, that's always a bad idea.

What kind of slot do blankets have? Outer? Is there anything in outer layer that shouldn't be allowed?

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

Yeah, outer. At first I think of it too, but there are anbc suit, hazmat suit, wolf suit, dinosaur suit and some others that I think wouldn't be good with footwear.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2016

But those aren't OVERSIZE. Anything OVERSIZE+OUTER that doesn't fit over boots?

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

No, I think there's nothing OVERSIZE+OUTER that doesn't fit over boots.

Night-Pryanik added some commits Apr 12, 2016

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

Done, I think.

@Coolthulhu Coolthulhu self-assigned this Apr 13, 2016

@Coolthulhu Coolthulhu merged commit bd6049f into CleverRaven:master Apr 13, 2016

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.

@Night-Pryanik Night-Pryanik deleted the Night-Pryanik:patch-5 branch Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.