Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove memorization of recipes from reading books. #17161
Conversation
Coolthulhu
self-assigned this
Jun 14, 2016
Coolthulhu
merged commit b7869d8
into
CleverRaven:master
Jun 14, 2016
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
Coolthulhu
referenced this pull request
Jun 15, 2016
Closed
Only memorize recipes when skill greatly exceeds requirements. #16564
kevingranade
deleted the
kevingranade:disable-recipe-memorization-from-books
branch
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedJun 13, 2016
Rebased from #7866
The current consensus has swung back to disabling memorization from reading entirely, so here's a PR that does so. After this change there is only one function of recipes in books, which is that when skimmed (identified) and nearby, they allow you to craft recipes (if you meet the other requirements).
Memorizing recipes only occurs when performing the recipes.