Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix construction id mismatch bug #17487
Conversation
Coolthulhu
added some commits
Jul 2, 2016
This comment has been minimized.
This comment has been minimized.
|
Does this with the first two commits of #17451 perhaps completely resolve the issue? |
mugling
self-assigned this
Jul 2, 2016
This comment has been minimized.
This comment has been minimized.
|
Yes, it does. Ive submitted a PR to your branch which includes resolving the merge conflict |
mugling
merged commit 38af8c7
into
CleverRaven:master
Jul 2, 2016
This was referenced Jul 2, 2016
Closed
mugling
added some commits
Jul 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedJul 2, 2016
Constructions will break if there are any blacklists that remove any constructions before the current one. That is because construction ids are set at load time, then not changed later.
Changed it by enforcing the ids after blacklists.
Note: this does NOT fix the bug with missing recipes (#17486), just blacklists causing constructions to get all weird. That is, cutting grass creating rock forges.