[CR]Regional weather settings

[Coolthulhu]

Per-regional-setting temperature, humidity, pressure and acidity.
As an example I changed the desert region settings to be very dry and slightly warmer than default ones.

The acid setting isn't used anywhere, but someone might want to turn it on and it was trivial to add.

[CR] because I moved randomness seed from weather generator to game and weather generator out of game and into regional settings (which in turn are an overmap field). And because some of the code looks rather unelegant because of that.

[Coolthulhu]

Rebased

[Coolthulhu]

Rebased

[mugling]

Sorry I haven't given this much prior attention. I'm not completely certain what it does. Could you explain a little and I'll take a look?

[pisskop]

. <--

[Coolthulhu]

Could you explain a little and I'll take a look?

Moves the responsibility to provide weather data from game to overmap. This allows regional settings to change the weather settings, thus allowing (some parts of) weather to by set by jsons. Not much - just amplitudes - but it's still a necessary step towards json weather.

[mugling]

I'm struggling to rebase, in particular init.cpp:212

[Coolthulhu]

Rebased on my side just fine. Could be different mergetools or git settings. Will push if it compiles and works.

[Coolthulhu]

OK, I think I got it working.
Desert worlds have rare rains, while default ones have common rains (as in master).

[mugling]

How do I generate deserts?

[Coolthulhu]

When generating a world, there is a terrain type option defaulting to "default". It should allow switching it to desert_test (or test_desert).
Sometimes it does not allow selecting due to a bug. In this case a game must be loaded, then exited to menu (without closing the game), then a new world must be created.

[mugling]

Still fails to compile at init.cpp:212

[Coolthulhu]

What error?
Jenkins doesn't have problems with it, so it's probably Clang being stricter than GCC.

[codemime]

It's safely defined in game_constants.h.

[codemime]

Do these variables have to be public?

[mugling]

src/init.cpp:212:5: error: no matching member function for call to 'add'
    add( "weather_settings", &weather_generator::load );
    ^~~
src/init.cpp:96:25: note: candidate function not viable: no known conversion from 'weather_generator (*)(JsonObject &)' to 'std::function<void (JsonObject &, const std::string &)>' for 2nd argument
void DynamicDataLoader::add( const std::string &type, std::function<void(JsonObject &, const std::string &)> f )
                        ^
src/init.cpp:104:25: note: candidate function not viable: no known conversion from 'weather_generator (*)(JsonObject &)' to 'std::function<void (JsonObject &)>' for 2nd argument
void DynamicDataLoader::add( const std::string &type, std::function<void(JsonObject&)> f )

[BevapDin]

The static load function loads and returns the object, but it's not stored anywhere. And there is no object with "type": "weather_settings" in any JSON file, so this will (currently) not be triggered anyway. The code for the regional settings loads the generator explicitly, without using the DynamicDataLoader.

[mugling]

So we can just drop the offending line entirely?

[mugling]

Now compiles ok