Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the error when the 'memorial' dir was not found. #17825

Merged
merged 1 commit into from Jul 30, 2016

Conversation

Projects
None yet
3 participants
@Soyweiser
Copy link
Contributor

commented Jul 28, 2016

See this http://smf.cataclysmdda.com/index.php?topic=12936.15 topic, when there memorial dir didn't exist there was an error message creating the nested directories.

This should fix this.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2016

Could we not just revert the original bad commit?

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2016

Well, that doesn't implement the feature of different memorial dirs per world. Which was the reason I made the first pr.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2016

We still have no way of testing these changes and given that the first PR was trivial yet still resulted in issues it's perhaps not encouraging to make further changes

@Coolthulhu Coolthulhu self-assigned this Jul 30, 2016

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2016

When I noticed the problem on the forums, I asked a friend if she could test it on a win10 machine. (To reproduce the bug). While reproducing, I found the bug myself (on my win7 machine). So I could ask her to test it again on the win10 one.

I have tested it myself by removing the memorial dir. (Something I had not tested before, (assumptions, ass me etc)).

@Coolthulhu Coolthulhu merged commit a983c8d into CleverRaven:master Jul 30, 2016

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2016

Testing if the dir exists and creating it if it doesn't should be pretty safe and shouldn't introduce other problems.

@Soyweiser Soyweiser deleted the Soyweiser:Memorial_Dir_Fix branch Aug 1, 2016

@Soyweiser

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2016

Asked my friend to test on win10. Works there as well. No error messages creating a world and suicide a char.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.