Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed the error when the 'memorial' dir was not found. #17825
Conversation
This comment has been minimized.
This comment has been minimized.
|
Could we not just revert the original bad commit? |
This comment has been minimized.
This comment has been minimized.
|
Well, that doesn't implement the feature of different memorial dirs per world. Which was the reason I made the first pr. |
This comment has been minimized.
This comment has been minimized.
|
We still have no way of testing these changes and given that the first PR was trivial yet still resulted in issues it's perhaps not encouraging to make further changes |
Coolthulhu
self-assigned this
Jul 30, 2016
This comment has been minimized.
This comment has been minimized.
|
When I noticed the problem on the forums, I asked a friend if she could test it on a win10 machine. (To reproduce the bug). While reproducing, I found the bug myself (on my win7 machine). So I could ask her to test it again on the win10 one. I have tested it myself by removing the memorial dir. (Something I had not tested before, (assumptions, ass me etc)). |
Coolthulhu
merged commit a983c8d
into
CleverRaven:master
Jul 30, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Testing if the dir exists and creating it if it doesn't should be pretty safe and shouldn't introduce other problems. |
ghost
referenced this pull request
Jul 31, 2016
Closed
Failed with DEBUG print when writing memorial file #17808
Soyweiser
deleted the
Soyweiser:Memorial_Dir_Fix
branch
Aug 1, 2016
This comment has been minimized.
This comment has been minimized.
|
Asked my friend to test on win10. Works there as well. No error messages creating a world and suicide a char. |
Soyweiser commentedJul 28, 2016
See this http://smf.cataclysmdda.com/index.php?topic=12936.15 topic, when there memorial dir didn't exist there was an error message creating the nested directories.
This should fix this.