Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChanges error message you get when there you have no butchering tool. #17891
Conversation
Coolthulhu
self-assigned this
Aug 5, 2016
Coolthulhu
merged commit d8d9109
into
CleverRaven:master
Aug 5, 2016
1 check passed
default
This has been rescheduled for testing as the 'master' branch has been updated.
Soyweiser
deleted the
Soyweiser:Sharp_Butcher_string
branch
Aug 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Soyweiser commentedAug 2, 2016
"You don't have a sharp item to butcher with." -> "You don't have a butchering tool."
The error message was confusing for at least one person ( http://smf.cataclysmdda.com/index.php?topic=13013.0 ). So I thought it would be better to make a direct reference to the tool quality type used in the message.
Tested it with a corpse on the ground and no butchering tool. Then dropped t-shirts (which you can disassemble) and got the following messages: http://prntscr.com/c0ikb6 so seems to work as intended. The variable *no_knife_msg is slightly misnamed I would say, as it seems like it looks for a butchering tool. Not a cutting one. (It does say quality_id( "BUTCHER" ) above it so not a huge problem).