Adds Filth Tolerant trait

[DangerNoodle]

Adds trait to mitigate filthy clothing effect. Reasoning: psychopath is a trait that affects morale-only things, and flithy clothes are currently a morale effect. Trait point cost is inverse of squeamish, can be increased if desired.

Practical effects for filthy clothes will still apply if they exist or are added.

[DangerNoodle]

?

Not very used to this.

[Treah]

Should make it so that they actively enjoy being filthy and will get a hit in moral if they are clean.

[DangerNoodle]

Would be odd, plus this is just tolerance, not enjoyment. Working on fixing code in general.

[DangerNoodle]

astyle regressions found.
Formatted  src/morale.cpp
make: *** [astyle-check] Error 1
make: INTERNAL: Exiting with 3 jobserver tokens available; should be 2!

This is new. I do not know how I styled it wrong. Surprised this is the only error reported in second commit.

[Zilenan91]

This is just a band-aid fix to a problem that should just be removed.

If people don't like filthiness they'll just be told to take the trait rather than there being actual debate on if it's worth keeping it in the game in the first place

[DangerNoodle]

I agree, but the feature likely will not be removed. It is better to have some way around this trait, than to leave it simultaneously annoying and mandatory.

Now, what am I missing here? I seem to have fixed the actual code, but some part of my formatting is generating an error. I'm not very familiar with the astyle demands.

[BorkBorkGoesTheCode]

Is this it?

[DangerNoodle]

Outdated. Fixing solved nothing.

[Zireael07]

To fix the style part you need to find astyle program and run it. @Coolthulhu probably knows more than I :P

[DangerNoodle]

I have no idea where to look for this, but I will try.

[DangerNoodle]

Still working on procuring astyle checker, updating repository, and trying it. But the only visible possible style failure I can see might be caused by FILTH_TOLERANT being just long enough to affect spacing for player_morale::mutation_data::clear()

[DangerNoodle]

There. Just a matter of getting astyle instead of relying upon my poor memory of style rules.

Now I will just need to make Squeamish and Filth Tolerance cancel each other out. In addition, should I add the trait to the medieval peasant profession, to add to the intended humorous flavor?

Or we could merely add Squeamish as a banned trait, if adding a 1-point trait is a bad idea.

[Coolthulhu]

I'd much rather get rid of the whole filthiness morale thing.
Quick fixes like that make it look like we're OK with it.

[DangerNoodle]

But is that ever going to happen? We can always remove this trait if we remove filth morale entirely.

Dropping this pull request because of that leaves the current system broken, and still forces it upon players.

[mugling]

Superseded by #18233

[DangerNoodle]

Ah, thank you. Apologies for not being on to close this myself.