New Mutation Category: Lamia

[evilexecutive]

Alright, this has actually been asked of me to do for awhile, both by my friends and several people on the forums awhile back. With this PR, I hope to add the ability for survivors to become a snek girl. For now I only have a single 'style' of snake tail that can be obtained, and that's an armoured lamia. Future PRs will include the ability to become a water snake, constrictor, or a python.

This is also now the first entirely new mutation category, since mutations got jsonized!

The Lamia Mutation tree focuses mostly on mixing some of the benefits and downsides of lizard and elf. A pre-threshhold lamia is vulnerable, but still has access to a few beneficial traits to make up for it, while also having a big speed debuff. Post threshhold lamia becomes a sneeky snake worthy of being called SNAKE.

[evilexecutive]

And now for the slow crawl of "Wait for the interpreter to report an error, so I can fix it"...

[cainiaowu]

Or you can try to load them locally since it only has json change.

It will report error on load.

[evilexecutive]

I'm retarded like that, and only slightly off kilter from some wine. For now I just want to relax and wonder why a perfectly ordinary line is showing up red on the editor, despite having no conceivable problem to me.

[evilexecutive]

Why, how, and wut. It wants something different from a { to start the set, but I don't have a freakin' clue what's wrong now. >.<

[DangerNoodle]

Boop all the snoots?

[Rivet-the-Zombie]

Double space after all sentence breaks, please.

[Rivet-the-Zombie]

Skin grown over the mouth? Do they still have mouths after this? This description's wording is a bit confusing.

[evilexecutive]

Yea, I meant to say cheeks. My reference image for this whole spiel is obviously miia, and that lamia had snake scales on her cheeks.

[Rivet-the-Zombie]

I have no idea who that is, but thank you for changing it.

[evilexecutive]

Oh dear god you poor soul, you have never seen Monster Musume have you? Miia was a lamia from it, and one of the main characters from said show. It's an echi series, and a ridiculously popular one at that.

[Rivet-the-Zombie]

It sounds like I'm not the right demographic for it, plus I don't do Japanese cartoons; regardless, I like the sound of this strange new MUTCAT.

[evilexecutive]

I think at this point all of the errors are fixed, and this PR is ready to be pushed to mainline. Thanks everyone for helping me out with my work, and for pointing out all the errors and mistakes!

[Coolthulhu]

Here and in every similar example above:
Bracket should be closed on a new line, unless the whole block is on one line.
For example:

"one_line" : [ "ONE", "LINE" ],
"many_lines" : [
    "MANY",
    "LINES"
]

[Coolthulhu]

Reversible and autolearn being set to false is redundant - those two lines can be deleted

[evilexecutive]

If it's redundant here, it's redundant across the entirety of all of the mutation recipes. Should I then remove them from all of the other recipes while I'm at it, if that'll optimize the code a little more?

[Coolthulhu]

Mass fixes should be their own PRs. Just keep this one up to standards.

[evilexecutive]

Ah shoot, I went through and fixed the entirety of it after leaving my comment, then you commented while I went ahead and made said fixes. >.<

[Coolthulhu]

"amount":1 is redundant.
The line above can be condensed into one line (ie. qualities and the one quality in it). Otherwise "tools" should be on a new line.

[Coolthulhu]

Cooking oil is much cheaper than chitin. Don't you mean chitin meal or something like that?
Also, cooking oil is vegetable matter.

[evilexecutive]

No, I have cooking oil as a placeholder (and a cheeky reference to snake oil)there for a future PR, where I add in Snakeskin and other snakeskin related items. I'm not going to address it here, because I haven't set-out to make that kind of stuff in this PR.

[Coolthulhu]

Don't add placeholders like that. It's trivial to add it later and now it only causes extra "wtf"s.

[evilexecutive]

Yea, I've gone ahead and removed it. I'll leave Chitin there though.

[pisskop]

Has the endstage been tested?
Do the mutations offered for lamia also contribute to select other categories?

>.>
<.<

Do I have to be a snek girl?

[evilexecutive]

Yes you can be a Snek Boy. Endstage is working fine, although there aren't too many lamia mutations post-threshhold at this time(and there won't be until I figure out how to code things like unique attacks from mutations).

None of the post-thresh lamia mutations contribute to other categories at this time, ESPECIALLY not the tail. I explicitly do not want the tail to be obtainable from other categories because the pre-thresh tail is actually a very strong negative trait. So it would be mighty inconvenient to other mutation trees if you could just spontaneously obtain a 3 foot long snake tail.

[ABlitzkriegOfButts]

This seems really kewl, Is there a download link yet?

[evilexecutive]

If the gods are willing, this will be mainlined into an experimental branch. So eventually, provided kevin signs off on it.

[evilexecutive]

Wait, why is this now producing errors? Also, how did it go so long without ever being pulled that it now starts producing errors?..

This isn't something I can fix..

[DangerNoodle]

Jently has been having issues as of late, it would seem.

[evilexecutive]

Well, whatever the problem is, it doesn't seem to be on my end of the code. I hope it gets resolved eventually, and that my PR gets pulled. >.<

[DangerNoodle]

Same, there are multiple pull requests this will have an effect on, but I do not know the full extent of the "out of memory" problem at present.

[mugling]

Try and avoid unrelated changes in the same PR

[mugling]

JSON load errors and touches a lot of unrelated data (especially recipes) so will merge conflict easily.

Closing as it's going to merge conflict as I merge other PR's and the fastest route for you would be to submit a new PR containing just the relevant changes and with the JSON errors fixed.

Alternatively you can rebase and reopen this PR if you have the git-fu