Move filthy morale penalty to a mod

[Coolthulhu]

Take 2.

At least 3 months and no real progress. Filthy clothing appears in every laundry list of new additions that didn't work out. We can bring it back into mainline when it gets good, but for now it's better for it to stay in a mod.

Fixes #17254

[kilozombie]

as others have said about similar subjects (gun magazines, for one), moving controversial features to mods means that it gets less criticism/changes

let's keep it in until we figure out a way to change it, or if we're going to remove it/keep it in its current state. no need to put more misc. features for a user to have to make a decision on, we already have too many of those in worldgen.

i mean, if it were my decision, a lot of these mods (blazemod and PK's mod) would be mainline... simply because they enhance the game in ways that i've seen most new players enjoy. even with this filthy clothes thing, if it were made into a mod nobody would pick it and nobody would propose new issues/PRs to change it.

[Coolthulhu]

3 months was enough for criticism. There were some ideas, but those got criticized too.
It doesn't need criticism, it needs implementing said criticism. Hence this PR.

[DangerNoodle]

I am not sure if this will get approved. If so, I can close my pull request adding filth tolerance. Given the dislike the filth system has generated, moving it to a mod might be sensible.

[pisskop]

why didnt the squeamish trait work out again?

as far as something that activated the filthy clothing?

something like #18229

[DangerNoodle]

Filth currently applies to everyone. Filth Tolerant only disables it.

[Zilenan91]

For something like magazines there was controversy over it but their implementation genuinely made guns have more utility and improved them. Filth just makes it so you can't use zombie clothes until late-game when you have infinite clean water, at which point their usefulness will have expired.

Either way this is great. It lets people work on filthiness until it's been improved to the point that it can go back in mainline.

[kilozombie]

ah, i suppose that's fair, if you're planning to make changes on it while it's out of mainline.

[DangerNoodle]

I suppose that makes sense. Either way, we need some method to fix current implementation, to make it not as pointless a feature.

My problem here is that the current conflict in pull requests, and conflicting ideas on how to fix filthy clothing, will delay a timely solution. I am fine with dropping my pull request if needed. It would conflict with this PR by Coolthulhu, but should be compatible with the pull request @mugling has.

[Coolthulhu]

Mugling's PR is abandoned and would need heavy updating anyway.

[DangerNoodle]

Unfortunate. In that case, if our PRs are incompatible, I can close mine and hope that yours gets merged. The trait and effects of it can always be added to said mod after this is implemented.

[mugling]

It would conflict with this PR by Coolthulhu, but should be compatible with the pull request @mugling has.

Mugling's PR is abandoned and would need heavy updating anyway.

I haven't worked on #17591 for some time so it shouldn't be seen as an obstacle to other work on the issue. One of the goals of that PR was to provide the original developer some breathing space to work on improving the feature but as they now appear absent this is less of a priority. I had hoped we could retain the contributor and whilst I can only speculate at their motivations I doubt the vitriol on the forums has been helpful.

3 months was enough for criticism. There were some ideas, but those got criticized too.
It doesn't need criticism, it needs implementing said criticism

Endless discussion isn't necessarily good. Talk is cheap whereas code (and maintaining it) is not. Ultimately those who contribute the most code are going to have the most influence of the direction the project takes. The filthy clothing feature is incomplete and now lacks a maintainer. I'm going to merge this PR solely because there isn't a better implementation available and the author has a track record for code maintenance.

[DangerNoodle]

Ah. Any method that resolves the problems with the implementation of filthy clothing in a satisfactory manner is good. Shifting it to a mod is likely a better method than the stopgap measure of giving Squeamish an opposing trait like I was doing.

[Night-Pryanik]

If anyone interested, I abandoned the project not because of lack of willingness or time, but due to fundamental disagreements on design matters.

[DangerNoodle]

Unfortunate. But yes, I was afraid that differing opinions on how to handle the feature would be detrimental to resolving the problems that caused such controversy over it.