Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mshock tileset additions and revisions [RDY] #18380

Merged
merged 3 commits into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@BorkBorkGoesTheCode
Copy link
Contributor

commented Sep 17, 2016

I made a few changes to some gun sprites: The extra white pixels on one of the magnums are gone, the PPSH has a straight magazine, some of the lumpiness on one of the SMG magazine has been fixed, I frankenstein'd a new sprite for the SVS-24c and the Rivtech combat armor.

The mininuke launcher looked too much like the Fallout mininuke launcher, so I created a new sprite for it. The Boba Fett Rivtech helmet is gone as well. Both are still present in some of the Chezzo tilesets; they may need to be removed in future.

This will be my first attempt at tileset revision. @Mshock777 , do you object to this?

@BorkBorkGoesTheCode BorkBorkGoesTheCode changed the title Mshock updates Mshock tileset additions and revisions Sep 17, 2016

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2016

What about opened and/or sealed cans, jars, cups, and other items? They no longer use existing spites due to changes in what item IDs occur.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2016

I will add those in a later PR.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2016

@illi-kun any objection to this?

@illi-kun

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

@BorkBorkGoesTheCode not from my side but unfortunately I'm not able to test Tiles Version due to technical issues on my side (have some issues with my main laptop and building the tiles=1 version on my backup netbook will take years).

@BorkBorkGoesTheCode BorkBorkGoesTheCode changed the title Mshock tileset additions and revisions Mshock tileset additions and revisions [WIP] Sep 17, 2016

@ghost

This comment has been minimized.

Copy link

commented Sep 17, 2016

Any plans on PK support?

@BorkBorkGoesTheCode BorkBorkGoesTheCode changed the title Mshock tileset additions and revisions [WIP] Mshock tileset additions and revisions [RDY] Sep 18, 2016

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2016

I don't have any sprites for it right now; I may add some in a later PR.

@mugling mugling self-assigned this Sep 19, 2016

@mugling

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2016

the PPSH has a straight magazine

Sprite doesn't appear for me

Can you list what is changed/needs testing

@mugling mugling removed their assignment Sep 19, 2016

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2016

@mugling Which tileset? How did you view it?

EDIT: The PPSH sprite itself had a curved magazine. I changed it.

Updated tiles_config
Thanks @mugling, I didn't check to see if the ppshmag or ppshdrum had a sprite. They now use the big pistolmag and drum mag sprites, respectively. @DangerNoodle, can_drink_unsealed now uses can_drink sprite. @ladyluck, I will be adding PK support in a later PR
@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2016

Ready to test now.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2016

@BorkBorkGoesTheCode can you list all the items changed?

@mugling mugling self-assigned this Sep 20, 2016

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2016

The mininuke launcher, SVS-24C and Rivtech helmet have new sprites. White pixels were removed from one of the revolver sprites; The PPSH smg sprite was changed, now its magazine is straight; Unsealed drink cans default to can_drink sprite; The PPSH-41 drum magazine uses the generic drum magazine sprite; The PPSH-41 magazine uses the generic extended pistol magazine sprite. Some lumpiness was removed from a smg sprite. I added my username to the credits.

The new SVS-24C sprite was derived from the SVS-24/24C sprites. The Rivtech helmet was derived from one of the shields and the hockey mask. I am the creator of the mininuke launcher sprite.

@mugling mugling merged commit 1cb329c into CleverRaven:master Sep 20, 2016

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
@mugling

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2016

...and the PR queue finally fits on a single page

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2016

Don't be so sure, I'm going to PR a rebalance to Icecoon's Weapons Pack.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2016

I forget whether or not Icecoon's Weapons Pack has magazines yet. If not, that would be an interesting thing to see.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2016

Ammo linkages are a big need, especially following #18362

@BorkBorkGoesTheCode BorkBorkGoesTheCode deleted the BorkBorkGoesTheCode:mshock-updates branch Oct 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.