Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMshock tileset additions and revisions [RDY] #18380
Conversation
BorkBorkGoesTheCode
added some commits
Sep 17, 2016
BorkBorkGoesTheCode
changed the title
Mshock updates
Mshock tileset additions and revisions
Sep 17, 2016
This comment has been minimized.
This comment has been minimized.
|
What about opened and/or sealed cans, jars, cups, and other items? They no longer use existing spites due to changes in what item IDs occur. |
This comment has been minimized.
This comment has been minimized.
|
I will add those in a later PR. |
This comment has been minimized.
This comment has been minimized.
|
@illi-kun any objection to this? |
This comment has been minimized.
This comment has been minimized.
|
@BorkBorkGoesTheCode not from my side but unfortunately I'm not able to test Tiles Version due to technical issues on my side (have some issues with my main laptop and building the tiles=1 version on my backup netbook will take years). |
BorkBorkGoesTheCode
changed the title
Mshock tileset additions and revisions
Mshock tileset additions and revisions [WIP]
Sep 17, 2016
This comment has been minimized.
This comment has been minimized.
ghost
commented
Sep 17, 2016
|
Any plans on PK support? |
BorkBorkGoesTheCode
changed the title
Mshock tileset additions and revisions [WIP]
Mshock tileset additions and revisions [RDY]
Sep 18, 2016
This comment has been minimized.
This comment has been minimized.
|
I don't have any sprites for it right now; I may add some in a later PR. |
mugling
self-assigned this
Sep 19, 2016
This comment has been minimized.
This comment has been minimized.
Sprite doesn't appear for me Can you list what is changed/needs testing |
mugling
removed their assignment
Sep 19, 2016
This comment has been minimized.
This comment has been minimized.
|
@mugling Which tileset? How did you view it? EDIT: The PPSH sprite itself had a curved magazine. I changed it. |
This comment has been minimized.
This comment has been minimized.
|
Ready to test now. |
This comment has been minimized.
This comment has been minimized.
|
@BorkBorkGoesTheCode can you list all the items changed? |
mugling
self-assigned this
Sep 20, 2016
This comment has been minimized.
This comment has been minimized.
|
The mininuke launcher, SVS-24C and Rivtech helmet have new sprites. White pixels were removed from one of the revolver sprites; The PPSH smg sprite was changed, now its magazine is straight; Unsealed drink cans default to can_drink sprite; The PPSH-41 drum magazine uses the generic drum magazine sprite; The PPSH-41 magazine uses the generic extended pistol magazine sprite. Some lumpiness was removed from a smg sprite. I added my username to the credits. The new SVS-24C sprite was derived from the SVS-24/24C sprites. The Rivtech helmet was derived from one of the shields and the hockey mask. I am the creator of the mininuke launcher sprite. |
mugling
merged commit 1cb329c
into
CleverRaven:master
Sep 20, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
|
...and the PR queue finally fits on a single page |
This comment has been minimized.
This comment has been minimized.
|
Don't be so sure, I'm going to PR a rebalance to Icecoon's Weapons Pack. |
This comment has been minimized.
This comment has been minimized.
|
I forget whether or not Icecoon's Weapons Pack has magazines yet. If not, that would be an interesting thing to see. |
This comment has been minimized.
This comment has been minimized.
|
Ammo linkages are a big need, especially following #18362 |
BorkBorkGoesTheCode commentedSep 17, 2016
•
edited
I made a few changes to some gun sprites: The extra white pixels on one of the magnums are gone, the PPSH has a straight magazine, some of the lumpiness on one of the SMG magazine has been fixed, I frankenstein'd a new sprite for the SVS-24c and the Rivtech combat armor.
The mininuke launcher looked too much like the Fallout mininuke launcher, so I created a new sprite for it. The Boba Fett Rivtech helmet is gone as well. Both are still present in some of the Chezzo tilesets; they may need to be removed in future.
This will be my first attempt at tileset revision. @Mshock777 , do you object to this?