Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] Changing welding googles recipe skill requirements #18635
Conversation
Firestorm01X2
changed the title
Changing welding goggles recipe skill requirements
[RDY] Changing welding goggles recipe skill requirements
Oct 3, 2016
Firestorm01X2
changed the title
[RDY] Changing welding goggles recipe skill requirements
[RDY] Changing welding googles recipe skill requirements
Oct 3, 2016
mugling
merged commit 8aa3728
into
CleverRaven:master
Oct 3, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
|
What, not even a discussion? In what way does it make sense to use mechanics to craft welding goggles? If you're going to change it to something, change it to fabrication. |
This comment has been minimized.
This comment has been minimized.
Oskar636
commented
Oct 4, 2016
|
How about you make it use fabrication (3-4?) but require mechanics (2-3?)? Makes more sense to me but not sure that's how it works. |
This comment has been minimized.
This comment has been minimized.
|
Well. My opinionis is google_nv (night vision googles) |
Firestorm01X2
referenced this pull request
Oct 4, 2016
Closed
Correcting welding googles recepie if needed #18641
This comment has been minimized.
This comment has been minimized.
|
Let's discuss future changes (if needed) there: |
Firestorm01X2
deleted the
Firestorm01X2:gweld
branch
Oct 4, 2016
This comment has been minimized.
This comment has been minimized.
OP's arguments were reasonable and another developer also tagged it as in agreement. Prior to this PR there wasn't any discussion so a change from |
Firestorm01X2 commentedOct 3, 2016
•
edited
Welding googles recepie for some reason requires tailoring 4. I recommend to change it to require mechanics 3 (just like for crude welder) for multiple reasons: