Convert non-AMMO items to GENERIC

[mugling]

• Exploits #18828 to convert some items from AMMO to GENERIC
• Adds brass material for casings
• Allows specifying item:damage_states (minimum and maximum repair) via JSON

[mugling]

Ready

[Reclusive-reptile]

Considering that casings would be littered about in large numbers, (ie. a burst from the mini-gun) does the change from ammo to generic result in any slow down when large stacks of casings are spawned?

[mugling]

The code already spawns the cartridges individually so no that won't be changed

[Reclusive-reptile]

So a stack of 1000 casings wouldn't hurt performance? I recall rags and other generic items causing problems in large numbers, in the crafting UI for example.

[Coolthulhu]

That's actually an important observation.
Except maybe not performance itself, but memory.
How does it work with memory?

Also volume limit thing vs item count limit. Does it exhaust the volume limit?

I'd like the following tests (not unit, can be just "manual"):

• Spawn 200 casings, drop them as one action
• Measure memory of DDA, spawn 1000 casings, measure memory again, drop 1000 casings, measure memory
• Spawn and drop 5000 casings

The above is because I really don't trust our item dropping system. I tried dropping 4000 rags and had to kill the process.

5000 one is an overkill so it's fine for it not to work, but the 1000 one should perform at least tolerably.

[Coolthulhu]

Doesn't work well.
For one, dropping each casing takes a whole turn, meaning that you will spend 5 minutes dropping a pocketful of casings.
Dropping a significant number of casings (200, which can actually spawn) takes very noticeable amount of time.

[mugling]

The memory issue isn't going to bite here but it could be a significant obstacle elsewhere so needs further consideration

[mugling]

So given item stacking is inherently evil (just the confounding with charges) see the simple changes in a02b828 that allow some GENERIC items to become stackable. We therefore get the performance advantage of stacking whilst still avoiding JSON obfuscation.

[mugling]

Of the open PR's that I have #18836 and #19020 are the most important so marked as priority