Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine cleanup #19051

Merged
merged 4 commits into from Nov 1, 2016

Conversation

Projects
None yet
4 participants
@mugling
Copy link
Contributor

commented Oct 31, 2016

Some initial cleanup to keep down line count of a big reworking of vehicle engines that will follow.

First two commits are migrations and linting. Third deprecates the useless plasma engine and the associated hydrogen tank. Once we have generic engine fuels via JSON we can add some more interesting alternatives then.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2016

Why can't you make the plasma engine useful instead of dropping it?

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2016

Because it uses a very rare resource that everyone wants for diamond weapons.
It's a money-fueled furnace.

{ "napalm_tank", { "tank", "napalm" } }
{ "napalm_tank", { "tank", "napalm" } },

{ "hydrogen_tank", { "tank", "plasma" } }

This comment has been minimized.

Copy link
@Coolthulhu

Coolthulhu Oct 31, 2016

Contributor

That is unlikely to work, as plasma is a solid.

This comment has been minimized.

Copy link
@mugling

mugling Oct 31, 2016

Author Contributor

Lets go with none then. The odds of anyone having plasma in a tank are defacto zero given how exceedingly rare it is and the other uses being much more valuable (plasma weapons and cvd machines)

@mugling

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2016

Because it uses a very rare resource that everyone wants for diamond weapons.
It's a money-fueled furnace.

It's entirely non salvageable in it's current form. Once we have generic fuel we can add lots more novel items

@Coolthulhu Coolthulhu self-assigned this Nov 1, 2016

@Coolthulhu Coolthulhu merged commit 3793d3f into CleverRaven:master Nov 1, 2016

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
@SeanMirrsen

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2016

It's entirely non salvageable in it's current form. Once we have generic fuel we can add lots more novel items

Proper steam boilers? Stirling engines? Wind-up mechanics? Wind power? :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.