Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEngine cleanup #19051
Conversation
This comment has been minimized.
This comment has been minimized.
|
Why can't you make the plasma engine useful instead of dropping it? |
This comment has been minimized.
This comment has been minimized.
|
Because it uses a very rare resource that everyone wants for diamond weapons. |
Coolthulhu
reviewed
Oct 31, 2016
| { "napalm_tank", { "tank", "napalm" } } | ||
| { "napalm_tank", { "tank", "napalm" } }, | ||
|
|
||
| { "hydrogen_tank", { "tank", "plasma" } } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mugling
Oct 31, 2016
Author
Contributor
Lets go with none then. The odds of anyone having plasma in a tank are defacto zero given how exceedingly rare it is and the other uses being much more valuable (plasma weapons and cvd machines)
This comment has been minimized.
This comment has been minimized.
It's entirely non salvageable in it's current form. Once we have generic fuel we can add lots more novel items |
mugling
added some commits
Oct 31, 2016
Coolthulhu
self-assigned this
Nov 1, 2016
Coolthulhu
merged commit 3793d3f
into
CleverRaven:master
Nov 1, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
Proper steam boilers? Stirling engines? Wind-up mechanics? Wind power? :P |
mugling commentedOct 31, 2016
Some initial cleanup to keep down line count of a big reworking of vehicle engines that will follow.
First two commits are migrations and linting. Third deprecates the useless plasma engine and the associated hydrogen tank. Once we have generic engine fuels via JSON we can add some more interesting alternatives then.