[RDY] Add 'Swamps' as viable overmap_special Locations

[pisskop]

A good example of something that can/should/may be able to spawn in a swamp:

-A swamp version of a pond, salted
-Hidden Temples
-plantations, survivalist compunds, hunter's shacks
-Stash houses
-LMOEs
-Toxic waste dumps
-Really anything that would be reclusive and 'top_secret"

[codemime]

Please don't introduce unused locations: they can become perfect candidates for removal at some point. It would be great to actually use it.

[DangerNoodle]

Maybe an alternative would be for this to be implemented by "in swamp" as a viable option for mapgen specials? Similar to how field, forest, and on water are all options.

I can see that being more versatile, for example used in Mining Mod.

[codemime]

Maybe an alternative would be for this to be implemented by "in swamp" as a viable option for mapgen specials? Similar to how field, forest, and on water are all options.

What do you mean by the option? All locations listed in the map are supposed to be used in JSON.

[pisskop]

"swamp" is what I named -allow_location_forest_water" renaming this in_swamp would result in the same behavior.

Adding in subterranean features should be as simple as using a "forest_water" surface and whatever json underneath.

[DangerNoodle]

I just realized that I misread the intent of this pull request, which is adding exactly what I was suggesting. My apologies.

[pisskop]

Its ready

[vache]

Anything with an underground feature would definitely NOT be spawned in a swamp.

[pisskop]

Im not sure why you would think that. Below the water table swamps are like any other rock.

[DangerNoodle]

See also, the concept of bog iron, for something specific to my plans for what I could do with this feature.

[pisskop]

Can this be rejected or committed

[Coolthulhu]

It looks mergeable, it's just that we aren't doing any merge runs at the moment due to shortage of dev time.

We may need to get more people with merge rights.

[pisskop]

Thats fine. Too many merges from my own branch. rather just reopen it

[DangerNoodle]

That may be desirable, if you know any regular contributors familiar enough with the code?