Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support total conversion mods #19260

Merged
merged 8 commits into from Nov 19, 2016

Conversation

Projects
None yet
3 participants
@mugling
Copy link
Contributor

commented Nov 12, 2016

Groundwork for supporting total conversion mods. A conceptually much simpler approach than the previous whitelisting attempts (which were complex and contained many bugs).

  • Initial cleanup of mod loading code
  • Adds support for core content packs which are loaded before all other content
  • dda is the first core pack and also enabled by default for all games
  • Unit tests and --dump-stats both use the dda core content pack
  • Almost all mods currently depend upon dda
  • Fully backward compatible with all savegames

Next step is to move the minimal number of items from dda to data/core and then other contributors can begin to write total conversion mods.

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Nov 12, 2016

This seems like the inevitable evolution of our mod manager. Cool idea!

@mugling

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2016

Added bonus: non-content mods (for example fast zombies) are now much quicker via --check-mods

@Coolthulhu Coolthulhu self-assigned this Nov 16, 2016

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2016

--check-mods spews many pages of errors.

@Coolthulhu Coolthulhu removed their assignment Nov 16, 2016

@mugling mugling force-pushed the mugling:mod5 branch to 5e93d77 Nov 16, 2016

@mugling

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2016

Found it - some mods were lacking a dependency on dda - all mods are going to require this until we have moved the minimal definitions required to prevent load errors to core. Should be fixed by latest commit.

@Coolthulhu Coolthulhu self-assigned this Nov 19, 2016

@Coolthulhu Coolthulhu merged commit 0aa4ae0 into CleverRaven:master Nov 19, 2016

1 check passed

default This has been rescheduled for testing as the 'master' branch has been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.