[RDY] Crafting Overhaul: Tailoring

[ZhilkinSerg]

A couple of months ago I've created Crafting Overhaul: Tailoring mod (see http://smf.cataclysmdda.com/index.php?topic=13880.0).

With this mod enabled you won't need to reload your sewing tools with threads/fiber/sinews anymore when crafting textile items - just have it available in your possession (inventory or nearby).

There weren't too much hype in the forums, but still I want to move these changes into core.

P.S.: I hope @kevingranade hasn't changed his mind and will still vote "Yes". 🇧🇫

[WizardOfOoo]

This is a very good idea, and once it's perfected, it could be expanded to welding and the like... maybe even letting a welder take charges from a storage battery?

Did you resolve the repair/reinforce issue you had? Or do you still need to load the tool to do repairs?

[DangerNoodle]

Interesting concept, but some flaws.

First, yarn is not included in the recipes, when it is a usable thread.
Second, this does not yet resolve the greater tedium of needing to load the tools to repair items, but I understand this will require more complex changes.
Third, any changes to Arcana and Magic Items or PK Rebalance mods will additionally warrant informing both mod authors of this change, as both are maintaining this mod in separate repositories.

[DangerNoodle]

Lastly, running the changed recipes through the online web linting tool ( http://dev.narc.ro/cataclysm/format.html ) will help with current commit failure cause.

[ZhilkinSerg]

Thanks for the feedback! What a shame I forgot about yarn.

[Coolthulhu]

You shouldn't directly copy+paste all the thread/sinew/fiber/yarn entries but should use the "using" syntax instead. Check out how is it done with "adhesive": it is defined in data/json/requirements/materials.json, then used in, for example, data/json/recipes/armor/head.json.

[ZhilkinSerg]

@Coolthulhu, there was some reason I didn't use "using", though "filament" material requirement was added.

[ZhilkinSerg]

Thanks, @kevingranade!

It seems I have issue number one in here - I didn't use fetch and rebase, but did pull.

Do I need to cancel this pull request and create a new one after fetching and rebasing (probably with single commit for all of the changes)?

[Chezzo]

Plant fibers work as thread too.

[ZhilkinSerg]

Plant fibre were originally in recipes together with threads and sinews.

Anyway I've changed all recipes to use filament material requirement, so one can easily add more thread variants without need to change all of the recipes in the future.

[Coolthulhu]

The sewing machine should be a separate PR. It needs to be cleaned up a bit before merging, while the filament change could go in now.
Problems include:

• Doesn't use power
• Isn't any faster than manual sewing
• Uses more materials for same repairs (this one could be an explicit disadvantage, but probably isn't intended)
• Has to be wielded to be used, which is tedious. Should probably wait until it can be used from the floor.

[ZhilkinSerg]

Thanks, I will remove sewing_machine from current PR.

[Coolthulhu]

You don't use that anywhere because you defined sewing quality instead.
You should either use the quality or the using, not both for the same thing.
Qualities are simpler, while usings are easier to extend (for example, if you ever wanted to add an electric knitter that uses power, qualities would not work).

[ZhilkinSerg]

I only added sewing_machine to sewing_standard, but it is already used for repairing of vehicle roof_cloth (see data/json/vehicle_parts.json).

knitting_standard is not used anywhere, so I will remove it.

[ZhilkinSerg]

I just realized it is possible to replace tools with qualities in sewing_standard:

before:

{
    "id": "sewing_standard",
    "type": "requirement",
    "//": "Crafting or repair of fabric items",
    "tools": [ [ [ "sewing_kit", 1 ], [ "tailors_kit", 1 ], [ "needle_bone", 1 ], [ "needle_wood", 1 ] ] ]
},

after:

{
    "id": "sewing_standard",
    "type": "requirement",
    "//": "Crafting or repair of fabric items",
    "qualities": [ { "id": "SEW", "level": 1 } ],
},

That way we won't need to add new tools (like sewing_machine or electric_knitter) to toolsets.

[ZhilkinSerg]

Sorry for the strange double commits - I really should learn using git...

[WizardOfOoo]

Did you resolve the repair/reinforce issue you had? Or do you still need to load the tool to do repairs?

[ZhilkinSerg]

Nope, repairing/reinforcing still needs loaded tools, but that will be changed eventually.