Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] School mapgen JSONify #20304
Conversation
ZhilkinSerg
changed the title
School JSONify
[RDY] School mapgen JSONify
Feb 17, 2017
Night-Pryanik
reviewed
Feb 17, 2017
| { | ||
| "id": "school_vehicles", | ||
| "type": "vehicle_group", | ||
| "//": "School bus or fire truck found near school locations", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
Feb 17, 2017
Author
Contributor
That was not my idea - see https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/mapgen.cpp#L5829.
This comment has been minimized.
This comment has been minimized.
kevingranade
Feb 17, 2017
Member
It's an emergency, school seems like a high priority place to dispatch EMS.
Coolthulhu
self-assigned this
Feb 23, 2017
Coolthulhu
merged commit 085bcfe
into
CleverRaven:master
Feb 23, 2017
1 check passed
default
Details
ZhilkinSerg
referenced this pull request
Feb 23, 2017
Closed
"Loaded bad ter! ter school_x" bug #20355
Coolthulhu
referenced this pull request
Feb 23, 2017
Merged
Revert "[RDY] School mapgen JSONify" #20361
This comment has been minimized.
This comment has been minimized.
|
I don't know how to fix the migration error and the error corrupts saves, so it is reverted for now. |
This comment has been minimized.
This comment has been minimized.
|
@Coolthulhu, once I get the fix, should I put all the changes (including changes from original commit) to new pull request or only savegame fix? |
This comment has been minimized.
This comment has been minimized.
|
All |
Night-Pryanik
referenced this pull request
May 24, 2017
Closed
JSONifying Garages and Adjusting drop rates after spawn fix #21049
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-school
branch
Aug 29, 2017
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedFeb 17, 2017
•
edited
Conversion of
schoolmapgen frommap::draw_mapto JSON.