[RDY] Prison mapgen JSONify

[ZhilkinSerg]

Conversion of prison mapgen from map::draw_map to JSON.

[Reclusive-reptile]

Should jumpsuit be replaced with striped_shirt and striped_pants? Prison wardens generally don't like inmates concealing stuff in ample pocket space.

[ZhilkinSerg]

Jumpsuits were in original mapgen - see https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/mapgen.cpp#L7354.

I believe we better change loot once all mapgen is moved to json from cpp.

[kevingranade]

I agree, open a PR or issue to track updating the prision definition to use new items if you want (I don't think those existed when the prison layout was added).

[Coolthulhu]

"Visions of solitude" spawned in wrong place - above the ground
The entire lower level has benches on solid rock (visible with a clairvoyance artifact).

Other than that looks good.

[codemime]

This has multiple merge conflicts (with your other PRs that have been already merged).

[ZhilkinSerg]

I believe it will be better to jsonize mapgen one at a time. I will create new pull request. Thanks, @codemime.

[Coolthulhu]

It's easy to mass-test them, the only problem is that they conflict with each other.

You could have dependent PRs: create one branch with one jsonized mapgen, then create new one on this branch rather than on master. This ensures no conflicts between those two branches.

[ZhilkinSerg]

Thanks, @Coolthulhu. I thought about this, but had some doubts. Branches should be created and merged in certain order, right? Also won't there be conflicts, if I add some changes in parent branch, but won't add these changes to child branches.

[Zireael07]

@ZhilkinSerg You can easily merge parent branch into child branch, though.

[ZhilkinSerg]

Superseded by #20408