Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cemeteries non-mandatory #20445

Conversation

Projects
None yet
8 participants
@Coolthulhu
Copy link
Contributor

commented Mar 4, 2017

Cemeteries are big, require forest tiles, and thus notoriously fail to generate, even in totally standard worlds.
Our mapgen simply can't handle this specific case - even with a retry. The result is that declaring cemetery as mandatory generally only results in error messages on map generation.

Removed the mandatory count. Also disabled the start location that requires one.
Alternative would be to allow cemeteries to also generate in the middle of a field - football fields are similarly sized and do not cause problems.

I'm getting the errors pretty much every third mapgen
Also http://smf.cataclysmdda.com/index.php?topic=14229

@BrettDong

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

Yes this is a real problem, I get the mapgen retry prompt every time I create a new world. 😒

@HotSake

This comment has been minimized.

Copy link

commented Mar 4, 2017

IRL, people will put a cemetery pretty much anywhere they can find a plot of land, including in the middle of a city.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

There would be less need of it if small cities also potentially had smaller cemeteries, which could be potentially be single-tile memorial parks and therefore added to the default regional settings, either in the park list or shop list (park listing might be better).

@kolsurma

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2017

Does the world gen system allow for overloaded names? E.g. you'd have a 2x2 cemetery, a 3x3 cemetery, etc. Or even better, dynamically generated X by Y sizes.

@pisskop

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

aye, they can only spawn within a small radius of a city and in a forest. they weren't incredibly common before and now its just causing spam

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

I am uncertain why this did not start to become an acute problem until more recently, however.

@pisskop

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

because the game didnt spit out debug messages and stop the player from playing until recently. it merely skipped over the item since it didnt always find a city with a forest nearby

@ghost

This comment has been minimized.

Copy link

commented Mar 5, 2017

Can this be done with bandit camps as well? Getting a lot of problems with bandit camps on low City Spacing.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

The problem with bandit camps is that they are used in missions. Even then there is the risk of mission errors.

@kolsurma

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2017

Should the mission system have check if required terrain is nearby? E.g. If it can't find a close enough spot for the mission, try giving a different mission.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Mar 5, 2017

I'd prefer allowing them in forests or fields, making them only overwrite forest tles seems pretty arbitrary.

@YourCompanionCube

This comment has been minimized.

Copy link

commented Mar 12, 2017

Can we please get some version of this main-lined so that i can actually get a decent map to generate instead of spawning in an evac shelter far away from any city?

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

I have recently tested a build after having manually set minimum cemetery occurrences to zero. It still would frequently cite this error without specifying what overmaps are the cause.

@pisskop

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

The error itself needs tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.