Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMake cemeteries non-mandatory #20445
Conversation
Coolthulhu
added some commits
Mar 4, 2017
This comment has been minimized.
This comment has been minimized.
|
Yes this is a real problem, I get the mapgen retry prompt every time I create a new world. |
This comment has been minimized.
This comment has been minimized.
HotSake
commented
Mar 4, 2017
|
IRL, people will put a cemetery pretty much anywhere they can find a plot of land, including in the middle of a city. |
This comment has been minimized.
This comment has been minimized.
|
There would be less need of it if small cities also potentially had smaller cemeteries, which could be potentially be single-tile memorial parks and therefore added to the default regional settings, either in the park list or shop list (park listing might be better). |
This comment has been minimized.
This comment has been minimized.
|
Does the world gen system allow for overloaded names? E.g. you'd have a 2x2 cemetery, a 3x3 cemetery, etc. Or even better, dynamically generated X by Y sizes. |
This comment has been minimized.
This comment has been minimized.
|
aye, they can only spawn within a small radius of a city and in a forest. they weren't incredibly common before and now its just causing spam |
This comment has been minimized.
This comment has been minimized.
|
I am uncertain why this did not start to become an acute problem until more recently, however. |
This comment has been minimized.
This comment has been minimized.
|
because the game didnt spit out debug messages and stop the player from playing until recently. it merely skipped over the item since it didnt always find a city with a forest nearby |
This comment has been minimized.
This comment has been minimized.
ghost
commented
Mar 5, 2017
|
Can this be done with bandit camps as well? Getting a lot of problems with bandit camps on low City Spacing. |
This comment has been minimized.
This comment has been minimized.
|
The problem with bandit camps is that they are used in missions. Even then there is the risk of mission errors. |
This comment has been minimized.
This comment has been minimized.
|
Should the mission system have check if required terrain is nearby? E.g. If it can't find a close enough spot for the mission, try giving a different mission. |
This comment has been minimized.
This comment has been minimized.
|
I'd prefer allowing them in forests or fields, making them only overwrite forest tles seems pretty arbitrary. |
This comment has been minimized.
This comment has been minimized.
YourCompanionCube
commented
Mar 12, 2017
|
Can we please get some version of this main-lined so that i can actually get a decent map to generate instead of spawning in an evac shelter far away from any city? |
This comment has been minimized.
This comment has been minimized.
|
I have recently tested a build after having manually set minimum cemetery occurrences to zero. It still would frequently cite this error without specifying what overmaps are the cause. |
This comment has been minimized.
This comment has been minimized.
|
The error itself needs tweaking. |
Coolthulhu commentedMar 4, 2017
Cemeteries are big, require forest tiles, and thus notoriously fail to generate, even in totally standard worlds.
Our mapgen simply can't handle this specific case - even with a retry. The result is that declaring cemetery as mandatory generally only results in error messages on map generation.
Removed the mandatory count. Also disabled the start location that requires one.
Alternative would be to allow cemeteries to also generate in the middle of a field - football fields are similarly sized and do not cause problems.
I'm getting the errors pretty much every third mapgen
Also http://smf.cataclysmdda.com/index.php?topic=14229