Worlds without filthy mod won't show coloring and suffix on filthy items

[Night-Pryanik]

Closes #20454.

That check was somehow removed after #18233.

[kevingranade]

#20454 is invalid, this is working as intended.

[DangerNoodle]

What is your reasoning for this issue being considered invalid?

[kevingranade]

#20454 (comment)

[DangerNoodle]

I do not see this as a valid reasoning. If the clothing does not have any gameplay effect without the mod enabled, there is minimal benefit gained in having them display as filthy when there is no consequence for wearing filthy clothing without the mod enabled.

In contrast, there is potential for player confusion caused by players assuming that the cosmetic effect indicates that filthiness behavior is occurring even without the mod enabled.

In fact, the comment you linked to does not actually present an argument in favor of leaving this as-is. It fallaciously claims that filthiness is an undesirable trait even when it has no effect. It cannot have an undesirable effect if it has no effect.

[Coolthulhu]

Seriously?
Misleading players with UI bullshit is a horrible practice.

I'm getting flashback to the time when someone thought that spamming the messagebox with "you are addicted to fungus" was anything but fucking idiotic.

[DangerNoodle]

Misleading players with UI bullshit is a horrible practice.

I fully agree. There is no valid benefit from leaving the current user interface behavior.

[Zireael07]

Why was this closed? The UI shouldn't present information that is not pertinent (without the mod the player doesn't care about filthiness)

[kevingranade]

Ok I'm convinced I'm in the wrong here, sorry for being stubborn about it.

In particular, closing this with "bla is invalid" was rude, my intent was, "discussion should happen over there", but obviously my carelss and abrupt wording didn't get that across.

Thanks for everyone her, on the forums and on discord for setting me straight.