Egglaying

[AlecWhite]

This PR makes monster lay eggs:

• Added EGGLAYING flag to monster.
• Added egglaid effect of 2 days max duration.
• Monsters with the EGGLAYING flag will lay an egg every 2 days.
• Chickens now lay eggs.
• Added òn_idle() method and called it in move().
• òn_idle() method defaults to stumble() when the monster can't do any special action.
• EGGLAYING monsters will only lay eggs on furniture with the NEST flag.
• Added lay_egg attack and add it to chickens.
• Added animal box and its recipe.
• Added NEST flag for furniture
• Animal box is used the same way as pet carrier but they are craftable.
• Added makeshift nest and its recipe.

As always I tried to be as less invasive as possible, and due to my little knowledge of how things work I opted to do it the easiest way.

Will work on a poultry farm soon.

[Coolthulhu]

I'd leave that for much later.
Egg laying will not work as nicely as milking - the result will be chickens laying fresh eggs when you pass by and random eggs littering the landscape.

For proper egg laying, the animals should have an AI that directs them into their nest before laying eggs and more "conscious" egg laying.
Not to mention that there is still no way to herd chickens properly.

[BrettDong]

There should be a period. Some translators complained to me about the inconsistency of the period symbols at the end of the strings in game recently so I'm paying attention to that in new PRs.

[BorkBorkGoesTheCode]

Could some method of converting eggs into chickens be implemented now, or in a later PR?

[AlecWhite]

For proper egg laying, the animals should have an AI that directs them into their nest before laying eggs and more "conscious" egg laying.
Not to mention that there is still no way to herd chickens properly.

If that's the general consensus, I'm going to see if I can understand and work a way with the AI(is it basically in monmove.cpp for the AI and game::monmove() with some tidbits spread in monster.cpp to actually make them move right?) to make them move to a nest tile. The whole scanning an area from the chicken's position to search of a nest is going to the FUN to figure it out.
I think if I change the pet menu stuff and make the examinemonsters.cpp/.h I could make so chickens only lay eggs if fed and after the laidegg effect is off.
But again, don't take that as a promise, I'm too noob at C++ to work fast or work well. And generally documentation regarding the AI is too little to compensate for my noobness, so it is going to be a try and error thing(pretty much like everything else I made so far). But then it will be fun to try.

Could some method of converting eggs into chickens be implemented now, or in a later PR?

Short answer yes, long answer:
Wouldn't be too hard to make roosters go to a mob and mate with them(I think), but I still have to see a way to make roosters only mate with chickens and not with any other entity.
But then I would need a way to track the health of the fertilized eggs, and make the eggs check for the temperature each turn and then make them hatch. And another way to make chicks grow.

[kevingranade]

You're going to want two different pieces of code for placing eggs. The main piece would retroactively place eggs when egg-laying birds are loaded onto the map, the secondary piece would have the same birds move to a nesting area when they are ready to lay eggs, then produce eggs. A key thing to remember is which is primary and which is secondary. We expect the vast majority of eggs to be placed when the player is not nearby, so the "on-load" code places most of the eggs. The AI code is just there to keep things consistent in the rare case that the player happens to be nearby when birds are laying eggs.

Also you're going to want some special handling for eggs disappearing, to avoid the player coming across huge caches of eggs late in the game. In reality it's cyclic and you would expect to find similar amounts of eggs independent of date (unless you add in something for seasonal laying rates).

[Night-Pryanik]

Tab instead of spaces.

[Night-Pryanik]

Tab instead of spaces.

[AlecWhite]

Close as I would need stuff in #21272 to start taming the chickens so they don't flee from you.

[kevingranade]

Even when tame, chickens scatter when people approach. If you want to farm chickens you either let them free range and go hunt down eggs, or you put them in an enclosure.

[DangerNoodle]

Even when tame, chickens scatter when people approach. If you want to farm chickens you either let them free range and go hunt down eggs, or you put them in an enclosure.

Enclosing livestock is something players will likely do anyway, as you would expect tame animals to potentially wander off even if they do not actively flee the player, in addition to players wanting to prevent them from being harmed.

[AlecWhite]

Even when tame, chickens scatter when people approach. If you want to farm chickens you either let them free range and go hunt down eggs, or you put them in an enclosure.

My idea was doing something like http://dwarffortresswiki.org/index.php/DF2014:Nest_box coupled with https://www.omlet.co.uk/guide/chickens/chicken_care/how_to_tame_your_chickens

And for chickens laying eggs retroactively on on load, I would need a some kind of next, to control the amount of eggs laid, and to have a place for the eggs to go. Plus that would require to assign a nest for each chicken if you want them to lay egg.

[kevingranade]

Something like a nest box is fine, it would just be a piece of furniture that's an ideal nest, so whatever nest-selection code we use would prefer it.

You don't get tame chickens unless you model raising them from chicks, the default is semi-tame chickens, so you need to handle that. You can add hand-rearing if you like, but it will never be the default.

Yes you need code that finds a nest, you need code that regulates number if eggs laid, you need code to avoid crowding. These are just what's required for the thing you're adding.

[AlecWhite]

You convinced me to do it without monexamine stuff.

[mouseturd]

Not sure if this is doable - but with my chickens at home, the only way to "herd" them is to chase them, pick them up, then throw them in their fenced enclosure.

Is there a way of "picking up" or "grabbing" a chicken or other small furry animal at this time?

[kevingranade]

Is there a way of "picking up" or "grabbing" a chicken or other small furry animal at this time?

There is not, but it wouldn't be that hard to add.

[DangerNoodle]

There is not, but it wouldn't be that hard to add.

Pet carrier?

[mouseturd]

If grabber zombies can move me around the map, it would be nice if we could do the same to animals.

…

On Jun 23, 2017 12:59 PM, "DangerNoodle" ***@***.***> wrote: There is not, but it wouldn't be that hard to add. Pet carrier? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#21261 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQjUcF0aCGiOaQHP5HqYErW4PCrb_KLHks5sG-7qgaJpZM4N9QFL> .

[Coolthulhu]

Don't implement it as an attitude, this will mess up the AI for other creatures. And also be slow, since attitude checks are common.
Instead, check the egg laying where you currently check the new attitude.
Or better yet: create an "on idle" method, which you invoke in that place, then do the egg laying check in that method.

[AlecWhite]

What do you mean by "on idle" method? Calling a method that checks if the monster is fed, searches for a nest and returns a tripoint assigning it to destination at the end of move()'s destination logic at line 550?

I don't fully understand how the AI works or how move() works but I don't mind trying it any other way as long as I'm not too noob to be able to. So any help and ideas I can get would awesome. And if I'm doing this I would rather do it the best possible way I can.

[Coolthulhu]

What do you mean by "on idle" method?

Just wrapping the code in a new method, as in monster::on_idle. Not necessary, it's just that it would be cleaner than dumping it directly into move.

[AlecWhite]

Not necessary, it's just that it would be cleaner than dumping it directly into move.

Thanks, I understand now, and it makes sense after reading the cooment about // TODO: Move this to attack_at/move_to/etc. functions.

And without the attitude check in which part inside of move() would be the correct place to call it?

[AlecWhite]

Time to see how to revert a branch in which I have merged the latest change of master. If anything github related weird things happens, it will be due to that.

Edit: I think I did it now I need to update the branch with the master changes and then work on it.

[AlecWhite]

15:32:19 ERROR: Format error at line 8273 15:32:19 < },{ 15:32:19 > }, 15:32:19 15:32:19 HINT: Canonical output for this block was:

No idea how to fix that.

[Coolthulhu]

No idea how to fix that.

Lint

[DangerNoodle]

You can use the linting tool here: http://dev.narc.ro/cataclysm/format.html

[BevapDin]

Deconstruction this gives much more rags and 2x4s than constructing it needs. Same with rags and bashing (construction requires 10 rags, bashing give 15-20).

[BevapDin]

Any reason why you moved a recipe into this file (which is for item definitions)? Why did you even touch that recipe at all?

[AlecWhite]

I mistakenly deleted that recipe and I mistakenly re-insert it on the wrong json.

[BevapDin]

Here you check for the flag via map::has_flag (which for example also considers flags of the terrain). In mattack::lay_egg, you check via furn_t::has_flag. This is inconsistent.

[BevapDin]

There is map::has_flag_furn when you want to check only the furniture for a flag. No need to get the furn_t here.

[BevapDin]

Parentheses around HOUR() are useless.

[BevapDin]

You should probably leave the loop after this via break. Currently the game would go on and check all the other tiles within range as well. The monster would essentially go to the furthest visible point.

[BorkBorkGoesTheCode]

I wonder if this could be used to create bee swarms which lay honey inside hollow trees.

[AlecWhite]

I wonder if this could be used to create bee swarms which lay honey inside hollow trees.

Everything is hardcoded, and wasn't made thinking of modularity and even less moddability, but wouldn't be too hard to do the bee swarms, as another hardcoded PR. Although it would probably need a few more requiremenst because of balance/realism and all that stuff.

And after saying this I should look at how to resolve conflicts in github.

[AMurkin]

Incorrect merge. JSON structure is broken.

[BevapDin]

, and '{' missing.

[BevapDin]

} and , and { missing.

[Coolthulhu]

Is this linted? It looks really bad.

[AlecWhite]

The linting tool doesn't like the fabrication field, so this time I'm going to pass it through without that field, and then add it later.

[Coolthulhu]

Needs a name

[Coolthulhu]

Not a switch, but rather something like monster attack - a json-coded function wrapper.

[Coolthulhu]

Styling

[kevingranade]

This needs to have some code that triggers when an EGGLAYING creature is loaded on the map to find a nearby next and populate it with some eggs.

[AlecWhite]

Wouldn't that assume that the area was safe of monsters and the player to not trigger the fleeing state?
I mean, part of making chickens non-tameable was to force them to first, protect them, secon; leave them alone and third; balance, as it would make otherwise an already very good source of food.

And now that I'm reminded of this. I'm still not completely happy with the balance of the egg spawn, after playing it for some time, as our most "hardcore" players may find it a bit too easy.

Would it be good if I added some way like with the milking to configure the cool down between laying eggs?

[kevingranade]

I'm not sure we're on the same page, as I said earlier, the vast majority of eggs would be laid when the player isn't present, there needs to be code to retroactively place those eggs when the player enters the area.

To put this another way, the way it works now is birds wait for the player to arrive before laying eggs, as soon as a bird spawns on the map, it will make a beeline for the nearest nest and immediately lay an egg. To see this in action, spawn a bunch of chickens and nests, leave the area, and return after several days have passed. All the chickens will run to the nests in unison and lay their eggs all at once. This is not an ok way for this to work.

[AlecWhite]

Closing due to private reasons.